Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display list names on the messages page #345

Merged
merged 2 commits into from Jun 29, 2018

Conversation

Projects
None yet
5 participants
@bramley
Copy link
Contributor

bramley commented Jun 6, 2018

Display the names of the lists to which a campaign has been or will be sent.

I have added a row to show the list names but there might be a better way of doing that. To avoid the "Lists" label, maybe append the list names to the campaign subject

image

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Jun 6, 2018

Why do you think it is necessary to add that there when the information is already available when clicking the "View" campaign option?

@bramley

This comment has been minimized.

Copy link
Contributor Author

bramley commented Jun 6, 2018

The benefit is seeing immediately the lists to which the campaign was sent or will be sent.

This arose because a client of mine composed a campaign and chose the wrong list. Looking at the Active tab of the messages page for confirmation he saw that it was scheduled to be sent but did not see that he had chosen the wrong list. Possibly the list names could be displayed only on the Active tab but I don't see a problem displaying on all the tabs.

@michield

This comment has been minimized.

Copy link
Member

michield commented Jun 6, 2018

It works when there is only one or a small number of lists, but what happens if the amount of lists is large?

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Jun 7, 2018

Yes, that's my concern too. I have seen very long list names too.
Also, I think adding this will put too much information on one page, making it as a whole less readable.

@samtuke

This comment has been minimized.

Copy link
Contributor

samtuke commented Jun 7, 2018

What about showing the lists only for active campaigns? Some users also have many campaign running simultaneously, I suppose, but still it would solve the visual clutter problem on the other tabs.

@bramley

This comment has been minimized.

Copy link
Contributor Author

bramley commented Jun 22, 2018

Perhaps display only a few list names with an indication of how many other lists were sent to.

This example displays a maximum of three lists. If there are more than three (actually four for this campaign) then only the first two are displayed with an indication of the number not being shown.
image

I'm not sure about long list names, possibly truncate to a length that will display reasonably in both themes. Is there anywhere else that list names are truncated?

Display the names of the lists to which a campaign has been or will b…
…e sent.

Limit to maximum of 3 list names

@bramley bramley force-pushed the bramley:display_list_names branch from 69ea9ee to d0dc998 Jun 24, 2018

@michield

This comment has been minimized.

Copy link
Member

michield commented Jun 24, 2018

Yes, that's quite nice, I think that would work. Even with long names, it wouldn't be too bad. It would probably be good if the "and 2 more" links to the place where this is expanded.

Add id to the target lists of the view message page.
Link "and n more" to the target lists.
@bramley

This comment has been minimized.

Copy link
Contributor Author

bramley commented Jun 28, 2018

Now made the "and n more" a link to the lists on the view message page
image

@michield michield merged commit 39e3d8f into phpList:master Jun 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michield

This comment has been minimized.

Copy link
Member

michield commented Jun 29, 2018

Great!

@bramley bramley deleted the bramley:display_list_names branch Jun 30, 2018

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Jul 5, 2018

@bramley I don't know if it was intentional but these changes are applied for sent campaigns too, not only those on the active tab. I thought we agreed on Sam's proposal to only do that for campaigns being sent ( as in that way it would address the problem you described earlier in the thread). @xh3n1 can work on reverting the commit related to the sent tab, but maybe you want to make the change yourself?

@bramley

This comment has been minimized.

Copy link
Contributor Author

bramley commented Jul 5, 2018

I thought we agreed on Sam's proposal to only do that for campaigns being sent

No, there wasn't any further discussion of the suggestion to limit the change to only the Active tab.

The vertical impact of the change is limited by displaying only three list names. Can you show a screenshot where that is too disruptive?

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Jul 5, 2018

@bramley I agree that isn’t too distruptive but, I can’t see any value on adding it there either. The problem you described is resolved with adding the lists on campaigns being sent. As per already sent campaigns the information is already there and easy accessible.

@xh3n1

This comment has been minimized.

Copy link
Member

xh3n1 commented Jul 5, 2018

Maybe we should revert the commit for the release branch and keep it on master for changes if needed? What do you think?

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Jul 5, 2018

I agree @xh3n1

@michield

This comment has been minimized.

Copy link
Member

michield commented Jul 5, 2018

I don't see a value in reverting. It's not obstructing anything, and reverting will increase the work involved, having to re-check it. For now, we should close this and leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.