Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display bounces per campaign #365

Merged
merged 10 commits into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@xh3n1
Copy link
Member

commented Jul 2, 2018

Signed-off-by: Xheni Myrtaj myrtajxheni@gmail.com

@xh3n1 xh3n1 closed this Jul 9, 2018

@xh3n1 xh3n1 force-pushed the msg-bounces branch from bfd2aea to 83261a0 Jul 9, 2018

xh3n1 added some commits Jul 2, 2018

display bounces per campaign
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Add bounces per campaign page to manage bounces
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@xh3n1 xh3n1 reopened this Jul 9, 2018

add the page title
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@xh3n1 xh3n1 force-pushed the msg-bounces branch from e5234db to f422708 Jul 9, 2018

add permission check
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@xh3n1 xh3n1 changed the title display bounces per campaign Display bounces per campaign Jul 13, 2018

xh3n1 added some commits Jul 16, 2018

add msgbouces to statistics
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
remove var_dump and print
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
use formatDateTime function
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
add option to download addresses
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@xh3n1 xh3n1 removed the on hold label Aug 10, 2018

@xh3n1 xh3n1 requested review from michield and samtuke Aug 10, 2018

@samtuke

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2018

@xh3n1 The layout of the page top buttons needs some work, and it would be good to add a dropdown list of other campaigns to navigate to, as is already provided on the 'bounces per list' page. Also stating the total bounces at the top, as on the other page, would be useful. See comparison of pagination and menu layout.

selection_466

selection_467

@samtuke samtuke removed the request for review from michield Aug 15, 2018

@xh3n1

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2018

Thanks for the review @samtuke , good points.

xh3n1 added some commits Aug 15, 2018

add select another campaign option
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
order by subject
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@xh3n1

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2018

screen shot 2018-08-15 at 23 59 18

@xh3n1 xh3n1 added the on hold label Aug 15, 2018

@samtuke samtuke requested a review from michield Aug 16, 2018

@samtuke samtuke merged commit cbdd474 into master Sep 19, 2018

3 checks passed

Scrutinizer 14 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@samtuke samtuke deleted the msg-bounces branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.