Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed url and regex fields from varchar to text and check if indexes exist #377

Merged
merged 4 commits into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@xh3n1
Copy link
Member

commented Jul 18, 2018

This is a PR for release-3.3.4

  1. Changed url fields from varchar to text
  2. Changed regex field from varchar to text
  3. Created a function to check if indexes exist
  4. Drop old indexes if they exist and then create new ones.

I have tested it on fresh new installations and upgraded and it works on my side. (I even tried manually removing an index and then upgrade). Anyway, this needs additional testing as in my opinion it's kind of sensitive.

xh3n1 added some commits Jul 17, 2018

change data field from blob to mediumblob
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Create fuction to check if index exist
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Changed fields and indexes for fresh new installations and upgrade
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@xh3n1 xh3n1 requested review from michield and samtuke Jul 18, 2018

create doc for the function
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@xh3n1 xh3n1 changed the title Changed url and regex fields from varchar to url and check if indexes exist Changed url and regex fields from varchar to text and check if indexes exist Jul 19, 2018

@michield michield merged commit 6f795f6 into release-3.3.4 Jul 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@xh3n1 xh3n1 deleted the index-exist branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.