New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantis 17649 Click tracking decoding urlencoded characters #407

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@bramley
Contributor

bramley commented Sep 21, 2018

This is a quick fix for Mantis 17649 https://mantis.phplist.org/view.php?id=17649

The problem is that, when trying to remove some specific query parameters from a url, the url can get changed or corrupted. The current processing breaks a url into its constituent parts then reassembles those, even when there is no need for that.

This change is simply to leave alone urls that do not contain any of the disallowed parameters.

A better, but larger, solution is to rework and simplify the processing of urls for link tracking.

@samtuke samtuke requested a review from xh3n1 Sep 21, 2018

@samtuke

This comment has been minimized.

Contributor

samtuke commented Sep 21, 2018

@bramley Many thanks Duncan

@michield

This comment has been minimized.

Member

michield commented Sep 23, 2018

Yes, agreed. Good to have a temp fix, and will be good to revisit this section.

@samtuke samtuke merged commit 616e8df into phpList:master Sep 28, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bramley bramley deleted the bramley:linktrack_cleanurl branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment