New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show bounces to transactional messages on the profile of a subscriber… #464

Closed
wants to merge 27 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@michield
Copy link
Member

michield commented Jan 8, 2019

…, and add an option on the reconcile page to process that retrospectively

show bounces to transactional messages on the profile of a subscriber…
…, and add an option on the reconcile page to process that retrospectively

@michield michield requested review from samtuke and xh3n1 Jan 8, 2019

@xh3n1 xh3n1 requested a review from suelaP Jan 16, 2019

@xh3n1

xh3n1 approved these changes Jan 21, 2019

Copy link
Member

xh3n1 left a comment

It looks good for me, but @suelaP will test this too.

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Jan 24, 2019

Hi Michiel,

@michield I have been checking these changes and whenever I click the "Associate system bounces to subscriber profiles"
The message I get on execution is:
"Relinking transactional messages that bounced to the related subscriber profile
4 to process
4 bounces have been associated with a subscriber profile"

I am unclear if it is intentional that:

  1. All bounces system messages are processed in each run?
  2. The date of the bounce on subscribers profile is updated to the last time that button was used.

If yes, wouldn't that be a problem when the number of those bounces is high?

@michield

This comment has been minimized.

Copy link
Member Author

michield commented Jan 24, 2019

Yes, very good point. I will update it to only process the ones that have not been associated yet.

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Jan 25, 2019

xh3n1 and others added some commits Jan 7, 2019

Relabel column to unique clicks
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Add total clicks
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Use separate table columns for clicks and the button
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Add total clicks to stats overview
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
save template with the same name after edit
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
vCard feature, added class, functions, etc
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Add vCard class
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Add type hinting
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
small fixes
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Remote processing validation (#460)
* Remove unnecessary validation of "secret" parameter

* Remove unnecessary validation of "secret" parameter.
Verify MANUALLY_PROCESS_BOUNCES only for browser processing, not for remote processing.

* Output only text, not any html, when in remote call.
Use global plugins and add other missing checks
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Let each tab have its own ordering.
Order the draft tab initially by modified date.
Ensure that the order by control shows the current ordering.
Avoid modifying $_GET.
Simplify assignment of $url_keep.

bramley and others added some commits May 25, 2017

@michield

This comment has been minimized.

Copy link
Member Author

michield commented Feb 6, 2019

Ok, funny one. I was trying to play with rebasing from master, but instead all commits to master have been pulled into this PR.

I'll continue to work on it, but before merging I'll redo it the Github way.

@michield

This comment has been minimized.

Copy link
Member Author

michield commented Feb 10, 2019

Ctd on #482

@michield michield closed this Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment