New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the values for the updatepassword radio buttons. #478

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@bramley
Copy link
Contributor

bramley commented Jan 31, 2019

I found weird behaviour when trying to send the password reset email on the Admin page.
The confirmation message didn't say that the email had been sent, but after a further change to an admin field it did say that.

An earlier change https://github.com/phpList/phplist3/pull/399/files#diff-151b5aaf0a8d1c46203a572c46ab3746L193 re-ordered the radio button captions from No then Yes to Yes then No but didn't modify the html attribute values, which meant elsewhere checks for Yes are being met when the No button is selected.

@samtuke samtuke requested a review from xh3n1 Jan 31, 2019

@xh3n1

xh3n1 approved these changes Feb 4, 2019

@samtuke samtuke merged commit 74484ba into phpList:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bramley bramley deleted the bramley:admin_password branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment