New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Text placeholder for Vcard and language fixes #479

Merged
merged 3 commits into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@xh3n1
Copy link
Member

xh3n1 commented Feb 7, 2019

  • Added text placeholder
  • Use defaultfrontendtexts as default.
  • Fixed typo

xh3n1 added some commits Feb 7, 2019

Use default frontend texts and fix typo
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Text placeholder
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Use defaultfrontendlanguage as default
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@samtuke samtuke merged commit 3a3e9ea into master Feb 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@samtuke

This comment has been minimized.

Copy link
Contributor

samtuke commented Feb 7, 2019

@suelaP Should this also be merged into the release branch? If so Xheni should create a separate PR for that.

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Feb 7, 2019

@samtuke yes that’s the plan. @xh3n1 will create another PR.

@xh3n1

This comment has been minimized.

Copy link
Member Author

xh3n1 commented Feb 7, 2019

@samtuke @suelaP done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment