Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to load default templates #487

Merged
merged 15 commits into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@xh3n1
Copy link
Member

xh3n1 commented Feb 27, 2019

Description

Users can choose from some available default templates to add by clicking the "Add default template" button.

Related Issue

https://mantis.phplist.org/view.php?id=19790

This is a draft PR (Thanks GitHub for this new feature 馃槂 ) for @suelaP to test the functionality.
The current values of templates are just for testing and can be updated later from @BrunildaDosti .

Add functionality to load default templates
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>

@xh3n1 xh3n1 requested a review from suelaP Feb 27, 2019

By default, add only 'System Template' as system template
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@suelaP
Copy link
Member

suelaP left a comment

This is working fine for me.

@BrunildaDosti

This comment has been minimized.

Copy link
Contributor

BrunildaDosti commented Mar 1, 2019

https://mantis.phplist.org/view.php?id=19790

Added three existing templates to phpList3(Suela suggestions and one premium template).

@samtuke

This comment has been minimized.

Copy link
Contributor

samtuke commented Mar 2, 2019

@xh3n1 This cannot yet be merged as it's still a 'draft'

@xh3n1 xh3n1 marked this pull request as ready for review Mar 2, 2019

@xh3n1

This comment has been minimized.

Copy link
Member Author

xh3n1 commented Mar 4, 2019

@samtuke this is not a draft anymore.

@suelaP suelaP requested a review from samtuke Mar 8, 2019

@samtuke samtuke merged commit 54698f1 into master Mar 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.