Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to List Templates page #516

Merged
merged 6 commits into from Apr 23, 2019
Merged

Conversation

@samtuke
Copy link
Contributor

samtuke commented Apr 18, 2019

Description

  • Add explicit edit button for each template to the 'list templates' page
  • Move edit buttons to same line, right side
  • Remove unnecessary ID column
  • Change table title
  • Add unique title for first column

Related Issue

Mantis : https://mantis.phplist.org/view.php?id=19761

Selection_561

@samtuke samtuke changed the title Templates page add edit button Improvements to List Templates page Apr 18, 2019
@samtuke

This comment has been minimized.

Copy link
Contributor Author

samtuke commented Apr 18, 2019

Known issues remaining:

  • border on every 2nd table row, despite removing setClass()
    (Fixed in phpList/phplist-ui-bootlist#87)
  • spacing between action buttons is inconsistent
  • padding of action button images is not centered
@samtuke

This comment has been minimized.

Copy link
Contributor Author

samtuke commented Apr 19, 2019

@BrunildaDosti Please work on the two issues CSS issues mentioned above at some point (FYI @suelaP)

@BrunildaDosti

This comment has been minimized.

Copy link
Contributor

BrunildaDosti commented Apr 19, 2019

@BrunildaDosti Please work on the two issues CSS issues mentioned above at some point (FYI @suelaP)

Ok. Sam.

@BrunildaDosti

This comment has been minimized.

Copy link
Contributor

BrunildaDosti commented Apr 23, 2019

@BrunildaDosti Please work on the two issues CSS issues mentioned above at some point (FYI @suelaP)

The PR for this issue:
phpList/phplist-ui-bootlist#89

@samtuke samtuke marked this pull request as ready for review Apr 23, 2019
@samtuke samtuke merged commit 6c4f3e1 into master Apr 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
@samtuke samtuke deleted the templates-page-add-edit-button branch Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.