Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inline attachments #521

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
4 participants
@lwcorp
Copy link
Contributor

commented Apr 28, 2019

Description

Added support for inline attachments like PDF files

Related Issue

https://mantis.phplist.org/view.php?id=15277

Screenshots (if appropriate):

@michield

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

It will be interesting to review the UX of this. With attachments being inline, it won't prompt for download of the file which may in some cases be more desirable. But I do think that most systems will then also allow a download option, so that will be fine.

@suelaP can you review and decide?

If the UX is fine, I'd be happy to merge this PR.

@suelaP

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@michield no UX changes are made and the attachments are included in the same way as before.
The difference is that when you send a message in Text format the link included at the bottom that says: " This message contains attachments that can be viewed with a webbrowser:
Location: http://mysite.com/lists/dl.php?id=14"
Will be opened in a Browser instead of prompting for download. Once you view the attachment in the browser you can then use the download option.
The same change is noticed when using the "Campaign Archive" option. Before these changes you could only download the attachment. Now you can open it in the browser instead.

@suelaP suelaP self-requested a review May 6, 2019

@suelaP

suelaP approved these changes May 6, 2019

@samtuke

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@suelaP Sounds like something to be documented in the manual?

@samtuke samtuke merged commit 1c49993 into phpList:master May 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.