Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification logic #525

Merged
merged 2 commits into from May 6, 2019

Conversation

Projects
None yet
3 participants
@xh3n1
Copy link
Member

commented Apr 30, 2019

Description

  • Return false if a production version is not found.
  • Updated PHPDocs.
  • Show notification only if the version is found in init.php.
  • Check if curl extension is loaded before checking for update.

Related Issue

TBA

xh3n1 added some commits Apr 30, 2019

Improve notification logic. Return false if a production version is n…
…ot found and don't display notification. Also, check if curl extension is loaded before checking for update.
Code reformat and update PHPdocs
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@suelaP
Copy link
Member

left a comment

@xh3n1 this uses curl and as per @bramley 's comment here: #513
we might want to reconsider adding more dependency on that module that has been optional until 3.3.7
FYI @samtuke

@samtuke

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@suelaP

we might want to reconsider adding more dependency on that module that has been optional until 3.3.7

Sorry which module?

@suelaP

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Sorry which module?

I read that wrong. This just checks if curl is there so it's OK.

@samtuke samtuke merged commit daab055 into master May 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@samtuke samtuke deleted the notification-logic branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.