Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When validating a subscription display all field errors #527

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
3 participants
@bramley
Copy link
Contributor

commented May 3, 2019

Description

When validating a subscription display all errors found instead of just one. This is one of the points raised in this forum post https://discuss.phplist.org/t/email-address-removed-if-captcha-wrong/5243

Related Issue

Screenshots (if appropriate):

Now shows all errors. In this case
country not selected
list not selected
captcha not entered (this is validation by a plugin)
a disposable email address has been used (again, validation by a plugin)

image

@samtuke samtuke requested a review from suelaP May 3, 2019

@suelaP

suelaP approved these changes May 3, 2019

@samtuke samtuke merged commit 89281fe into phpList:master May 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bramley bramley deleted the bramley:subscribe_errors branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.