Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MySQL Sessions work with PHP 7.2 #533

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
3 participants
@jesse-thomas
Copy link
Contributor

commented May 12, 2019

Description

Fix 500 Error with no error message under PHP 7.2 and make MySQL session handler work.

  • Tested to work with PHP 7.2 and 5.6
  • ini_set('session.save_handler', 'user') not allowed in php 7.2
  • The read callback must always return a session encoded (serialized) string, or an EMPTY STRING if there is no data to read.
Make MySQL Sessions work with PHP 7.2
Fix 500 Error with no error message under PHP 7.2 and make MySQL session handler work.
- Tested to work with PHP 7.2 and 5.6
- ini_set('session.save_handler', 'user') not allowed in php 7.2
- The read callback must always return a session encoded (serialized) string, or an EMPTY STRING if there is no data to read.

@samtuke samtuke requested a review from xh3n1 May 13, 2019

@jesse-thomas

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

I think this a duplicate of https://mantis.phplist.org/view.php?id=19936

except under php 7.2 I could not create a new session without changing the read call back to return '' instead of false for an empty value.

@xh3n1

xh3n1 approved these changes May 20, 2019

@samtuke samtuke merged commit 0609a30 into phpList:master May 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.