Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/19920 add uid on attachment download url #542

Merged
merged 3 commits into from Sep 5, 2019

Conversation

@michield
Copy link
Member

commented May 23, 2019

Description

Add UID to the download of attachments in text versions of emails

Related Issue

https://mantis.phplist.org/view.php?id=19920

michield added 3 commits May 23, 2019
…ad URL
@michield

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

The main problem on this is that

this will have an issue in upgrade. When a campaign has been sent on an older version without the "uid", it will stop providing the document and throw a 404. This only applies to attachments in text versions of the campaigns (very limited audience, presumably)

@suelaP is that acceptable, or do we need to create a way to alleviate this problem.

@samtuke samtuke requested a review from suelaP May 24, 2019
@samtuke

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@suelaP Ping

@suelaP
suelaP approved these changes Sep 5, 2019
@samtuke samtuke merged commit 68635d3 into master Sep 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@samtuke samtuke deleted the feature/19920-add_uid_on_attachment_download_url branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.