Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds senderid configuration and process to allow feedback loops to t… #547
Implements simple recommendation from https://support.google.com/mail/answer/6254652?hl=en
Allow phplist to be compliant with gmail feedback loop service
Screenshots (if appropriate):
changed the title
Adds senderid configuration and preocess to allow feedback lopps to t…
May 29, 2019
Thanks! Looks good. Regarding the senderid, that appears to be a hardcoded string, but shouldn't it be a different value for each host or installation? In which case it should probably be easier to set than by editing that hardcoded value. What is the impact of using this new header including literally the string 'senderid'? Presumably the feedback loop would fail.
Yes, it's a good idea, but needs some more detail to work as a feature that can be accepted.
The correct way to make this change is as follows:
As this is Google specific, it is probably even better to call it GOOGLE_SENDERID
Bonus points would be if the "a : b : c" from https://support.google.com/mail/answer/6254652?hl=en are implemented, ie "campaign ID", "subscriber ID" etc.
More bonus points would be to document it on the resources wiki.
As said I'm no real developer. I have followed Michiel's explanation. But didn't go for the extra mile as I'm not sure how/where to gather the campaingId and subscriber ID variables.