Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of id attribute with name in checkAllBoxes function-campaigns sending #560

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
3 participants
@BrunildaDosti
Copy link
Contributor

commented Jun 26, 2019

@BrunildaDosti BrunildaDosti requested a review from suelaP Jun 26, 2019

@suelaP

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

This fixes both issues reported.
However, for consistency it would be better if checking "Select All" doesn't actually check all boxes (visually). For example checking "All lists" when no categories are used, won't check all lists even though the campaign will be sent to all lists.

@suelaP

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Let's check the logic consistency after this is merged as this already fixes the original problem.

@suelaP

suelaP approved these changes Jul 5, 2019

@samtuke samtuke merged commit 56104d5 into master Jul 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@samtuke samtuke deleted the checkAllBoxes-in-a-category branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.