Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search list by name #565

Merged
merged 1 commit into from Jul 4, 2019

Conversation

Projects
None yet
4 participants
@xh3n1
Copy link
Member

commented Jul 3, 2019

Signed-off-by: Xheni Myrtaj myrtajxheni@gmail.com

Description

Make it possible to search for a list by name

Related Issue

https://mantis.phplist.org/view.php?id=19105

Screenshots (if appropriate):

Screenshot 2019-07-03 at 19 49 39

Screenshot 2019-07-03 at 19 49 48

Search list by name
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@samtuke

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

So great 🎊

@bramley

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

The Mantis issue refers to finding a list regardless of its category. This change doesn't appear to support that.

Currently the lists page doesn't seem to have a way to display lists regardless of category - it displays Uncategorised lists initially, then you can change category, but cannot display all lists. I'm not sure how simple it might be to make the search work across categories, and display the results.

@xh3n1

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@bramley I have created an issue for searching all lists and will implement it once it's supported :)
https://mantis.phplist.org/view.php?id=19961

@suelaP suelaP self-requested a review Jul 4, 2019

@suelaP

suelaP approved these changes Jul 4, 2019

@samtuke samtuke merged commit 7ec35cc into master Jul 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@samtuke samtuke deleted the search-lists branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.