Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more detailed subscriber click stats the userdataexport csv files #576

Merged
merged 8 commits into from Aug 5, 2019

Conversation

@samtuke
Copy link
Contributor

commented Jul 26, 2019

Data in the csv table 'User clicks Info' was missing due to the db query used. Replace the sql query to get data, and more data.

Also add a check for the forwarded email data to see if any results are returned, and if not, print message saying so.

Note: The behaviour of tables where no data is found is now inconsistent: all tables show col headings and no data, except for the forwarded message data table, which now does the table title and a message stating forwarded data is absent of that is the case. It would be good to add conditional checks to the other tables to test for this too in future.

@samtuke samtuke requested a review from suelaP Jul 26, 2019

@suelaP

suelaP approved these changes Aug 5, 2019

@samtuke samtuke merged commit 791a76d into master Aug 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@samtuke samtuke deleted the fix-missing-exportuserdata-data branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.