Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantis 20069 - Some quirks with simple paging #584

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@bramley
Copy link
Contributor

commented Sep 1, 2019

Description

When displaying a set of results using simple paging

  • Avoid paging past the final page.
  • Display only the remaining items on the last page.

Related Issue

https://mantis.phplist.org/view.php?id=20069

Screenshots (if appropriate):

Event log page showing the last page,
prior to change shows the last 50 events
Screenshot from 2019-08-27 08-25-14
after change shows the last 47 events

Screenshot from 2019-08-27 08-22-39

Avoid paging past the final page.
Display only the remaining items on the last page.

@samtuke samtuke requested a review from suelaP Sep 2, 2019

@michield

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Nice one

👍

@suelaP
suelaP approved these changes Sep 4, 2019

@samtuke samtuke merged commit 7fbb67f into phpList:master Sep 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bramley bramley deleted the bramley:Mantis_20069 branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.