Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting the database to UTF8 #616

Merged
merged 2 commits into from Dec 6, 2019
Merged

Converting the database to UTF8 #616

merged 2 commits into from Dec 6, 2019

Conversation

@bramley
Copy link
Contributor

bramley commented Dec 2, 2019

Description

Two changes to the page that converts the database to UTF8.

  • Avoid displaying the warning about lack of disk space when the database has already been upgraded to UTF8. Displaying the warning regardless had caused some confusion, see this topic in the user forum https://discuss.phplist.org/t/is-there-a-way-to-convert-database-to-utf8-by-command-line/5732/10

  • Currently the processing checks the space available on the drive with the root directory '/', which might not be the actual location of the database. mysql has a parameter, datadir, giving the location of the database that can be used instead of '/'.
    This change is also made to the upgrade page.

Related Issue

Screenshots (if appropriate):

@suelaP suelaP merged commit 4cf9016 into phpList:master Dec 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bramley bramley deleted the bramley:convert_utf8 branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.