Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the message bounces page display the bounce id #627

Merged
merged 2 commits into from Mar 5, 2020

Conversation

@bramley
Copy link
Contributor

bramley commented Jan 19, 2020

Description

The message bounces page has one row for each bounce for that campaign, but the rows do not show or link to the actual bounce. The rows also have two links to the subscriber page.

This change includes the bounce id as a link to the bounce page.

Related Issue

Screenshots (if appropriate):

Prior
Screenshot from 2020-01-19 21-02-20

After
Screenshot from 2020-01-19 21-04-09

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Mar 4, 2020

Screenshot_2020-03-04 phpList

I am not sure why but I get this error whenever the number of bounces includes is 1000 or higher, because it includes a comma. When the number is less then no error is displayed.

The version of my Mariadb is 10.3.17

@bramley

This comment has been minimized.

Copy link
Contributor Author

bramley commented Mar 4, 2020

I think that it is a mistake introduced when I reformatted one of the sql queries that occurs when there are more than 150 bounces. I should be able to confirm that tomorrow, and fix it.

There is also a spurious % character in the heading "24,331 bounces to campaign %s". The database table has two rows that give the same translation
image

@suelaP

This comment has been minimized.

Copy link
Member

suelaP commented Mar 4, 2020

I should be able to confirm that tomorrow, and fix it.

Thank you :) This is a very nice improvement to include in the upcoming upodate.
There is also a spurious % character in the heading "24,331 bounces to campaign %s". The database table has two rows that give the same translation
image
Yes, I noticed that but as it's not related to this change it can also be addressed separately.

@bramley bramley force-pushed the bramley:message_bounces_page branch from cc4eb0d to 14cc734 Mar 4, 2020
@bramley

This comment has been minimized.

Copy link
Contributor Author

bramley commented Mar 4, 2020

The cause of the sql syntax error has been corrected.

@suelaP suelaP merged commit 18f39e5 into phpList:master Mar 5, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bramley bramley deleted the bramley:message_bounces_page branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.