Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change URLs that already have a scheme #633

Merged
merged 1 commit into from Mar 5, 2020

Conversation

@bramley
Copy link
Contributor

bramley commented Feb 18, 2020

Description

A problem raised on the user forum regarding a link whose URL was a phone number, tel:1234, being changed to an http URL
https://discuss.phplist.org/t/problems-with-href-links/2026/9

When adding absolute resources leave alone URLs that already have a scheme. The regular expression allows any valid scheme as described at https://www.ietf.org/rfc/rfc2396.txt section 3.1.

Related Issue

Screenshots (if appropriate):

@suelaP suelaP merged commit 078bf34 into phpList:master Mar 5, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bramley bramley deleted the bramley:webpage_tel_link branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.