protect the invocation of the function output() #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during bounce processing the function output() can be called without be defined
Member
|
Thanks for this. Before we review and merge, do you mind signing the CLA? Thanks |
Contributor
Author
|
OK. CLA signed |
michield
approved these changes
Jul 27, 2023
Member
michield
left a comment
michield
left a comment
There was a problem hiding this comment.
Yes, that'll work. A possibly better solution is to provide the "output" function, which is done in various other "long running pages". By doing this some useful output will be missed.
marianaballa
added a commit
that referenced
this pull request
Aug 18, 2023
This reverts commit 99d0c8d.
marianaballa
pushed a commit
that referenced
this pull request
Aug 18, 2023
during bounce processing the function output() can be called without be defined
Contributor
|
This pull request has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/3-6-14-release-candidate-ready-for-testing/9109/1 |
Contributor
|
This pull request has been mentioned on phpList Discuss. There might be relevant details there: https://discuss.phplist.org/t/phplist-3-6-14-released-security-release/9158/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during bounce processing the function output() can be called without be defined
this is my call stack ( 3.6.13-RC1 )
( ! ) Error: Call to undefined function output() in /var/www/html/bollettino/lists/admin/lib.php on line 962
Call Stack
Time Memory Function Location
1 0.0001 394128 {main}( ) .../index.php:0
2 0.0158 949696 include( '/var/www/html/bollettino/lists/admin/processbounces.php ) .../index.php:759
3 0.0158 933424 getPageLock( $force = ??? ) .../processbounces.php:488
Description
Calling the function only if it was already declared
Related Issue
Screenshots (if appropriate):