Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login failed on on PHP 7.3.9 #19

Closed
dehim opened this issue Sep 4, 2019 · 5 comments
Closed

login failed on on PHP 7.3.9 #19

dehim opened this issue Sep 4, 2019 · 5 comments

Comments

@dehim
Copy link

dehim commented Sep 4, 2019

vi classes/Authorization.php

find "self::generateSalt(20)" -> "self::generateSalt(22)"

and it works.
@crazy4chrissi
Copy link
Contributor

crazy4chrissi commented Sep 4, 2019

Can you explain why this is necessary?

@crazy4chrissi
Copy link
Contributor

crazy4chrissi commented Sep 4, 2019

Ok, this is Blowfish so the salt for crypt should be 22 characters. Strange why it even worked before.

crazy4chrissi added a commit that referenced this issue Sep 4, 2019
@crazy4chrissi
Changed salt length to 22 characters as required for Blowfish. This s…
515f223 
…eemed to cause problems with PHP 7.3.9. This should solve #19
@crazy4chrissi
Copy link
Contributor

crazy4chrissi commented Sep 4, 2019

Can you please check whether the current development version works?

https://www.phpliteadmin.org/phpliteadmin-dev.zip

@dehim
Copy link
Author

dehim commented Sep 5, 2019

Can you please check whether the current development version works?

https://www.phpliteadmin.org/phpliteadmin-dev.zip

OK，it runs perfectly

@crazy4chrissi
Copy link
Contributor

crazy4chrissi commented Sep 5, 2019

Fixed with phpLiteAdmin 1.9.8.2 released just now.

@crazy4chrissi crazy4chrissi mentioned this issue Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crazy4chrissi @dehim