Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination does not work, conflicting class #173

Closed
andrewvh619 opened this issue Mar 13, 2021 · 4 comments
Closed

Pagination does not work, conflicting class #173

andrewvh619 opened this issue Mar 13, 2021 · 4 comments
Assignees
Labels
bug Fixed Fixed bug

Comments

@andrewvh619
Copy link
Contributor

ISSUE

The crud controller is causing errors on pagination as there are conflicting name space issue in CRUDController.

Error
Uncaught Error: Class 'Ubiquity\controllers\rest\ResponseFormatter' not found in /app/vendor/phpmv/ubiquity/src/Ubiquity/controllers/crud/CRUDController.php:109

Should be Ubiquity\controllers\rest\formatters\ResponseFormatter

https://www.loom.com/share/b2622ef6df6947b5b0ed420704c72975

Screenshot at Mar 13 12-56-21

Using:
master-dev
docker
mac
postgresql

@jcheron
Copy link
Contributor

jcheron commented Mar 13, 2021

Hi @andrewvh619 ,
Thank you for this report.
You know you can submit a PR, especially if you have found the problem and identified the solution to solve it.
Increasing the number of contributors is also a way to improve the credibility of a framework.

@jcheron jcheron added the bug label Mar 13, 2021
@jcheron
Copy link
Contributor

jcheron commented Mar 13, 2021

In this case, there is not only an import problem.
The dependency between the CRUD part and the Rest part must also be removed.

@jcheron
Copy link
Contributor

jcheron commented Mar 13, 2021

A PR is a github Pull Request, which is what allows you to make a proposal for a code correction.

To summarize, if you have a correction to make or if you want to propose an improvement :
You:

  • fork the project on your github account
  • clone the fork to work on it locally.
  • create a new branch correctly named
  • work on the code to modify or improve
  • commit and push your work
  • do a Pull Request (PR)

Your PR is then reviewed, possibly accepted as is, or you are asked to fix it.

see https://github.com/phpMv/ubiquity/blob/master/CONTRIBUTING.md

@andrewvh619
Copy link
Contributor Author

I will contribute in this manner. Thank you very much.

jcheron added a commit that referenced this issue Mar 13, 2021
Remove Rest response formatter from CRUD
see #173
@jcheron jcheron added the Fixed Fixed bug label Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixed Fixed bug
Projects
None yet
Development

No branches or pull requests

2 participants