Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front-end makeup #1

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
5 participants
@ChristianBullock
Copy link

commented Jul 16, 2013

Front-end updates for phpbb-ideas system.

  • "Added "new idea" button to top of pages where appropriate
  • Emphasised "View All" button
  • Added new "Vote up" and "vote down" buttons
  • Swapped out arrow up/down for thumbs up/down
  • Improved "people who have voted" panel


<div class="voteslist bg3">
<ul>

This comment has been minimized.

Copy link
@michaelcullum

michaelcullum Jul 16, 2013

Member

Is this massively indented or is it just Github?

This comment has been minimized.

Copy link
@callumacrae

callumacrae Jul 17, 2013

Contributor

Christian, you seem to be using spaces for indentation; as the rest of the file uses tabs, please could you convert them?

<dd class="topics">
<div class="minivoteup solid"><span>{latest_ideas.VOTES_UP}</span></div>
<div class="minivotedown solid"><span>{latest_ideas.VOTES_DOWN}</span></div>
</dd>

This comment has been minimized.

Copy link
@michaelcullum

michaelcullum Jul 16, 2013

Member

Indentation here also I think

<dd class="topics"><span class="up">&#x25B2;{top_ideas.VOTES_UP}</span> &nbsp; <span class="down">&#x25BC;{top_ideas.VOTES_DOWN}</span></dd>
<dd class="topics">
<div class="minivoteup solid"><span>{top_ideas.VOTES_UP}</span></div>
<div class="minivotedown solid"><span>{top_ideas.VOTES_DOWN}</span></div>

This comment has been minimized.

Copy link
@michaelcullum

michaelcullum Jul 16, 2013

Member

More indentation. I don't think your editor likes you. :(

@ghost ghost assigned callumacrae Jul 16, 2013

@michaelcullum

This comment has been minimized.

Copy link
Member

commented Jul 16, 2013

Do you have any screenshots you could post? Looks good from what I can see though. 👍 With indentation your editor seems to be a bit dodgy.

@ChristianBullock

This comment has been minimized.

Copy link
Author

commented Jul 16, 2013

Looks like Github. I've attached a screenshot of the beautifully indented code in the code editor. :) Also a couple of screenshots. Nothing major, but still some prettification. :)

2
code
1

@michaelcullum

This comment has been minimized.

Copy link
Member

commented Jul 27, 2013

@callumacrae What's the status with this? If it's fine then please merge it, if not please say what the problem is.

@callumacrae

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2013

I'm in France!

On 27 Jul 2013, at 19:50, "Michael C." notifications@github.com wrote:

@callumacrae What's the status with this? If it's fine then please merge it, if not please say what the problem is.


Reply to this email directly or view it on GitHub.

@michaelcullum

This comment has been minimized.

Copy link
Member

commented Jul 28, 2013

Can you still please check the diff and if it's good I can deal with the merging? I'd rather this was not left sitting here if it's finished and if it's not then the time can be used to fix it.

@michaelcullum

This comment has been minimized.

Copy link
Member

commented Jun 22, 2014

@callumacrae Bump... Could you handle this please?

@michaelcullum

This comment has been minimized.

Copy link
Member

commented Oct 7, 2014

@hanakin

This comment has been minimized.

Copy link
Member

commented Oct 8, 2014

ln 21-28 in screenshot is double tabbed? looks fine in code though

@VSEphpbb VSEphpbb referenced this pull request Oct 16, 2015

Merged

Complete MOD to Ext conversion #4

1 of 1 task complete
@callumacrae

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2015

@VSEphpbb @michaelcullum Was this included in the conversion? It was a good change

@VSEphpbb

This comment has been minimized.

Copy link
Member

commented Oct 19, 2015

Yes, but done even better. Except for the side by side sections which don't work now that there are three sections, and we need to be responsive.

@michaelcullum

This comment has been minimized.

Copy link
Member

commented Oct 19, 2015

@callumacrae So now you reply... But yes.

@ChristianBullock Thanks for your contribution.

@callumacrae

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2015

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.