Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
sql_return_on_error removal (11162) #1030
I have some changes here, but I have to go now. bantu/phpbb@phpbb:develop-olympus...bantu:ticket/11162
referenced this pull request
Nov 15, 2012
How about this contraption.
However, when testing it the topic_watch merging does not seem to work:
I checked develop which does not have this patch and behavior is the same. This is on postgres.
It does look like it should support a few other tables (forums_track, sessions_keys, topics_track, topics_posted, and zebra from what I saw).
Does topics_watch need anything special done to it besides this? This way it does not compare notify_status (although I am not exactly sure I understand what this is used for).
I think then that the function just may need a better name since it's dependent on the user_id, maybe phpbb_update_rows_avoiding_duplicates_per_user