New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11233] Prohibit selecting anonymous user as a PM recipient #1220

Merged
merged 1 commit into from Jan 30, 2013

Conversation

Projects
None yet
3 participants
@dhruvgoel92
Contributor

dhruvgoel92 commented Jan 28, 2013

@bantu

View changes

Show outdated Hide outdated phpBB/includes/ucp/ucp_pm_compose.php Outdated
@dhruvgoel92

This comment has been minimized.

Show comment
Hide comment
@dhruvgoel92

dhruvgoel92 Jan 28, 2013

Contributor

Thanks @bantu I have changed the condition.

Contributor

dhruvgoel92 commented Jan 28, 2013

Thanks @bantu I have changed the condition.

@bantu

This comment has been minimized.

Show comment
Hide comment
@bantu

bantu Jan 29, 2013

Member

@dhruvgoel92 Please change the commit message summary to be more clear/meaningful. E.g. "Disallow sending private messages to the guest user."

Member

bantu commented Jan 29, 2013

@dhruvgoel92 Please change the commit message summary to be more clear/meaningful. E.g. "Disallow sending private messages to the guest user."

@dhruvgoel92

This comment has been minimized.

Show comment
Hide comment
@dhruvgoel92

dhruvgoel92 Jan 29, 2013

Contributor

Thanks, I hope it is fine now?

Contributor

dhruvgoel92 commented Jan 29, 2013

Thanks, I hope it is fine now?

@bantu

This comment has been minimized.

Show comment
Hide comment
@bantu

bantu Jan 29, 2013

Member

@dhruvgoel92 Actually, it was never possible to send PMs to anonymous. According to http://tracker.phpbb.com/browse/PHPBB3-11233 you get an error message "No recipient defined.".

Member

bantu commented Jan 29, 2013

@dhruvgoel92 Actually, it was never possible to send PMs to anonymous. According to http://tracker.phpbb.com/browse/PHPBB3-11233 you get an error message "No recipient defined.".

@bantu

This comment has been minimized.

Show comment
Hide comment
@bantu

bantu Jan 29, 2013

Member

So should be something like "Disallow selecting guest user as a PM recipient." Sorry for the confusion.

Member

bantu commented Jan 29, 2013

So should be something like "Disallow selecting guest user as a PM recipient." Sorry for the confusion.

@p

This comment has been minimized.

Show comment
Hide comment
@p

p Jan 29, 2013

Contributor

"Prohibit selecting anonymous user as a PM recipient."

Do not mention "user id of 1" in commit message - refer to anonymous user as anonymous.

Contributor

p commented Jan 29, 2013

"Prohibit selecting anonymous user as a PM recipient."

Do not mention "user id of 1" in commit message - refer to anonymous user as anonymous.

[ticket/11233] prohibit selecting anonymous user as a PM recipient
While composing pm, it should not be allowed to add
anonymous user as a PM recipient

PHPBB3-11233
@dhruvgoel92

This comment has been minimized.

Show comment
Hide comment
@dhruvgoel92

dhruvgoel92 Jan 30, 2013

Contributor

Fixed.

Contributor

dhruvgoel92 commented Jan 30, 2013

Fixed.

@bantu

This comment has been minimized.

Show comment
Hide comment
@bantu

bantu Jan 30, 2013

Member

Thanks

Member

bantu commented Jan 30, 2013

Thanks

@bantu bantu merged commit 36b7d75 into phpbb:develop-olympus Jan 30, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment