New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11355] Wrong error message when no user is selected. #1234

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@erangamapa
Contributor

erangamapa commented Feb 18, 2013

In ACP group membership management, if you select 'remove member
from group' without selecting any users and submit,it will display
a wrong error after confirmbox. Since no users are selected, this
should not go even until confirmbox. Added a new condition to check
weather any users are selected when the action is 'deleteusers'
in acp_groups.php and disply a correct error.

PHPBB3-11355

[ticket/11355] Wrong error message when no user is selected.
In ACP group membership management, if you select 'remove member
from group' without selecting any users and submit,it will display
a wrong error after confirmbox. Since no users are selected, this
should not go even until confirmbox. Added a new condition to check
weather any users are selected when the action is 'deleteusers'
in acp_groups.php and disply a correct error.

PHPBB3-11355
[ticket/11355] Referred proper variable when validating selection.
Earlier PR was referring wrong variable $name_ary. Changed it to
$mark_ary which actually contains selected user ids.

PHPBB3-11355
@naderman

This comment has been minimized.

Show comment
Hide comment
@naderman

naderman Feb 24, 2013

Member

This was merged but I rebased it onto develop-olympus, so closing manually. Thanks!

Member

naderman commented Feb 24, 2013

This was merged but I rebased it onto develop-olympus, so closing manually. Thanks!

@naderman naderman closed this Feb 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment