New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][ticket/11595] REST API #1490

Closed
wants to merge 43 commits into
base: develop
from

Conversation

Projects
None yet
@galaxyAbstractor
Contributor

galaxyAbstractor commented Jun 24, 2013

Creating an API for phpBB to enable ease of access by other applications

PHPBB3-11595

@imkingdavid

This comment has been minimized.

Show comment
Hide comment
@imkingdavid

imkingdavid Jun 25, 2013

Contributor

As a side note, when you eventually add docblocks to the methods, please be sure to include a short, example of output. Also, you should probably make note of what kind of call needs to be made to that endpoint (e.g. GET, POST, PUT, DELETE, etc.).

Contributor

imkingdavid commented Jun 25, 2013

As a side note, when you eventually add docblocks to the methods, please be sure to include a short, example of output. Also, you should probably make note of what kind of call needs to be made to that endpoint (e.g. GET, POST, PUT, DELETE, etc.).

@naderman

This comment has been minimized.

Show comment
Hide comment
@naderman

naderman Jun 26, 2013

Member

Please format your code according to our guidelines, for example we do not use camel case. The method name addSubForum should be lower case separated by underscores.

Member

naderman commented Jun 26, 2013

Please format your code according to our guidelines, for example we do not use camel case. The method name addSubForum should be lower case separated by underscores.

@naderman

This comment has been minimized.

Show comment
Hide comment
@naderman

naderman Jun 26, 2013

Member

You should create tests for the API. The most suitable kind of test will be a functional test, which verifies the retrieved JSON matches the expectation.

Member

naderman commented Jun 26, 2013

You should create tests for the API. The most suitable kind of test will be a functional test, which verifies the retrieved JSON matches the expectation.

Show outdated Hide outdated phpBB/includes/controller/api.php
$forums = array();
foreach ($result as $row)
{
if($row['forum_id'] == $forum_id || $row['parent_id'] == 0)

This comment has been minimized.

@naderman

naderman Jun 26, 2013

Member

We place spaces after the if and before the (
Same applies for elseif - and elsewhere.

@naderman

naderman Jun 26, 2013

Member

We place spaces after the if and before the (
Same applies for elseif - and elsewhere.

Show outdated Hide outdated phpBB/includes/model/entity/forum.php
*/
class phpbb_model_entity_forum extends phpbb_model_entity
{
protected $forum_id;

This comment has been minimized.

@EXreaction

EXreaction Jul 8, 2013

Contributor

Might it be better to use a $data array to store all these items rather than list them individually? This way seems like a lot more work, especially if adding/removing columns.

@EXreaction

EXreaction Jul 8, 2013

Contributor

Might it be better to use a $data array to store all these items rather than list them individually? This way seems like a lot more work, especially if adding/removing columns.

This comment has been minimized.

@galaxyAbstractor

galaxyAbstractor Jul 8, 2013

Contributor

Hmm maybe. Coming from java before I did PHP, I thought of proper objects when naderman described his idea about using entities and such. Having an array with the columns wouldn't be much difference than just fetching the data from SQL and use that array directly, wouldn't it tho? I'm still a bit confused about this though as to me it seems like just an extra step between retrieving stuff from the database then serializing it for output?

@galaxyAbstractor

galaxyAbstractor Jul 8, 2013

Contributor

Hmm maybe. Coming from java before I did PHP, I thought of proper objects when naderman described his idea about using entities and such. Having an array with the columns wouldn't be much difference than just fetching the data from SQL and use that array directly, wouldn't it tho? I'm still a bit confused about this though as to me it seems like just an extra step between retrieving stuff from the database then serializing it for output?

This comment has been minimized.

@EXreaction

EXreaction Jul 8, 2013

Contributor

Everything would function the same if you change the set/get methods to do $this->data[$field], it just would mean that we don't have to add a variable for every column on every table and update it accordingly every time a new column is added/removed.

You would still want entity classes because functions can be added to it to make processing the data on it easier. For example, you might have a function here that returns the forum description prepared for display or edit (processes the bbcode)

@EXreaction

EXreaction Jul 8, 2013

Contributor

Everything would function the same if you change the set/get methods to do $this->data[$field], it just would mean that we don't have to add a variable for every column on every table and update it accordingly every time a new column is added/removed.

You would still want entity classes because functions can be added to it to make processing the data on it easier. For example, you might have a function here that returns the forum description prepared for display or edit (processes the bbcode)

Show outdated Hide outdated phpBB/includes/model/api/forum.php
*/
public function add_subforum($forum, $forums)
{
for ($i = 0; $i < count($forums);$i++)

This comment has been minimized.

@callumacrae

callumacrae Jul 10, 2013

Contributor

You're missing a space after the second semi-colon

@callumacrae

callumacrae Jul 10, 2013

Contributor

You're missing a space after the second semi-colon

This comment has been minimized.

@galaxyAbstractor

galaxyAbstractor Jul 10, 2013

Contributor

I'm gonna rewrite that function anyway >.<

@galaxyAbstractor

galaxyAbstractor Jul 10, 2013

Contributor

I'm gonna rewrite that function anyway >.<

Show outdated Hide outdated phpBB/includes/model/api/topic.php
$sql = 'SELECT *
FROM ' . TOPICS_TABLE . '
WHERE forum_id = ' . (int) $forum_id . '
ORDER BY topic_id DESC';

This comment has been minimized.

@callumacrae

callumacrae Jul 10, 2013

Contributor

I think your IDE is adding tabs here

@callumacrae

callumacrae Jul 10, 2013

Contributor

I think your IDE is adding tabs here

This comment has been minimized.

@galaxyAbstractor

galaxyAbstractor Jul 10, 2013

Contributor

Switched computer, forgot to fix settings, gonna fix that :)

@galaxyAbstractor

galaxyAbstractor Jul 10, 2013

Contributor

Switched computer, forgot to fix settings, gonna fix that :)

Show outdated Hide outdated phpBB/includes/model/normalizer/forum.php
{
public function normalize($forum, $format = null)
{
$normalized_forums = array(

This comment has been minimized.

@callumacrae

callumacrae Jul 10, 2013

Contributor

Might be cleaner to generate this array from another array - $normalised_forums = array('forum_id', 'parent_id', 'forum_name'...) and a foreach.

@callumacrae

callumacrae Jul 10, 2013

Contributor

Might be cleaner to generate this array from another array - $normalised_forums = array('forum_id', 'parent_id', 'forum_name'...) and a foreach.

This comment has been minimized.

@EXreaction

EXreaction Jul 11, 2013

Contributor

Another option might be to use a blacklist rather than a whitelist. I.e. get all in $data except certain fields that you don't want to list publicly (I'm assuming this normalize is to get the list of fields that might be used/requested for public use, right?)

@EXreaction

EXreaction Jul 11, 2013

Contributor

Another option might be to use a blacklist rather than a whitelist. I.e. get all in $data except certain fields that you don't want to list publicly (I'm assuming this normalize is to get the list of fields that might be used/requested for public use, right?)

This comment has been minimized.

@galaxyAbstractor

galaxyAbstractor Jul 11, 2013

Contributor

I agree that might be cleaner to generater from another array. About blacklist vs whitelist, could probably be done whatever ways. The difference is that with a blacklist you may accidentally leak information trough the API if you add a column with secrets and forget to update the normalizer, while with a whitelist you still have to update it if you add a column but you wont accidentally leak stuff. I doubt that would happen though.

@galaxyAbstractor

galaxyAbstractor Jul 11, 2013

Contributor

I agree that might be cleaner to generater from another array. About blacklist vs whitelist, could probably be done whatever ways. The difference is that with a blacklist you may accidentally leak information trough the API if you add a column with secrets and forget to update the normalizer, while with a whitelist you still have to update it if you add a column but you wont accidentally leak stuff. I doubt that would happen though.

Show outdated Hide outdated phpBB/config/routing.yml
_method: GET
api_topics_controller:
pattern: /api/topics/{forum_id}/{page}

This comment has been minimized.

@naderman

naderman Jul 11, 2013

Member

topic_id?

@naderman

naderman Jul 11, 2013

Member

topic_id?

This comment has been minimized.

@naderman

naderman Jul 11, 2013

Member

Should we be using page numbers or post offsets?

@naderman

naderman Jul 11, 2013

Member

Should we be using page numbers or post offsets?

Show outdated Hide outdated phpBB/includes/controller/api/auth.php
}
$this->template->assign_vars(array(
'S_AUTH_ACTION' => 'app.php?controller=api/auth/allow',

This comment has been minimized.

@naderman

naderman Jul 29, 2013

Member

Yes, you can generate URLs with the routing component too - see http://symfony.com/doc/current/components/routing/introduction.html#generate-a-url

@naderman

naderman Jul 29, 2013

Member

Yes, you can generate URLs with the routing component too - see http://symfony.com/doc/current/components/routing/introduction.html#generate-a-url

This comment has been minimized.

@galaxyAbstractor

galaxyAbstractor Jul 31, 2013

Contributor

Noticed the controller helper class has a function for this, $this->helper->url('api/auth/allow');

@galaxyAbstractor

galaxyAbstractor Jul 31, 2013

Contributor

Noticed the controller helper class has a function for this, $this->helper->url('api/auth/allow');

Show outdated Hide outdated phpBB/includes/model/entity/api_response.php
* Api response enitity
* @package phpBB3
*/
class phpbb_model_entity_api_response extends phpbb_model_entity

This comment has been minimized.

@naderman

naderman Jul 29, 2013

Member

Why is this class necessary and why is a response an entity? It would seem that responses should go somewhere else than into the model?

@naderman

naderman Jul 29, 2013

Member

Why is this class necessary and why is a response an entity? It would seem that responses should go somewhere else than into the model?

This comment has been minimized.

@galaxyAbstractor

galaxyAbstractor Jul 29, 2013

Contributor

I was thinking about the possibility of having extra data bundled with the JSON of say forums, like status codes and such but yeah it maybe isn't necessary. It's an entity as it uses the same structure as an entity but you're right, it should probably not be that kind of entity.

@galaxyAbstractor

galaxyAbstractor Jul 29, 2013

Contributor

I was thinking about the possibility of having extra data bundled with the JSON of say forums, like status codes and such but yeah it maybe isn't necessary. It's an entity as it uses the same structure as an entity but you're right, it should probably not be that kind of entity.

Show outdated Hide outdated phpBB/includes/model/repository/auth.php
}
return $key;
}

This comment has been minimized.

@naderman

naderman Jul 29, 2013

Member

Might be better to use phpBB's unique_id function for this which has better randomness because it uses a seed stored in the database.

@naderman

naderman Jul 29, 2013

Member

Might be better to use phpBB's unique_id function for this which has better randomness because it uses a seed stored in the database.

Show outdated Hide outdated phpBB/includes/model/repository/forum.php
{
$this->nestedset_forum = $nestedset_forum;
}
public function get($forum_id){

This comment has been minimized.

@naderman

naderman Jul 29, 2013

Member

Missing a newline before this and one before the bracket too

@naderman

naderman Jul 29, 2013

Member

Missing a newline before this and one before the bracket too

Show outdated Hide outdated phpBB/includes/model/repository/forum.php
return $forums;
}
/** @TODO: Something for nestedset? */

This comment has been minimized.

@naderman

naderman Jul 29, 2013

Member

Indeed, this should be moved to the nested set implementation.

@naderman

naderman Jul 29, 2013

Member

Indeed, this should be moved to the nested set implementation.

@naderman

This comment has been minimized.

Show comment
Hide comment
@naderman

naderman Jul 29, 2013

Member

Great progress, like where this is going! :)

Member

naderman commented Jul 29, 2013

Great progress, like where this is going! :)

@naderman

This comment has been minimized.

Show comment
Hide comment
@naderman

naderman Jul 29, 2013

Member

You may want to rebase this onto latest develop and resolve conflicts, so that it is easily mergable again. This will mean that you need to move your files to the phpbb/ directory rather than keeping them in includes/ - make a backup of your files first and ask on IRC if you need help with the rebasing.

Member

naderman commented Jul 29, 2013

You may want to rebase this onto latest develop and resolve conflicts, so that it is easily mergable again. This will mean that you need to move your files to the phpbb/ directory rather than keeping them in includes/ - make a backup of your files first and ask on IRC if you need help with the rebasing.

galaxyAbstractor added some commits Jun 9, 2013

[feature/api] Created a simple prototype of an API
A simple prototype that takes pathinfo and decides what function
to call. Currently lets you list forums. No input validation
or authentication/permission check.

PHPBB3-11595
[feature/api] Moved code to use controllers
Moved the earlier created API prototype to make use of controllers
and routing instead of having a front-facing file and a separate
class.

PHPBB3-11595
[feature/api] Using nested sets
Changed forum fetching to use the nested set class instead.
Now instead for using own SQL for fetching forums, it'll
fetch it using the nested set class. If fetching all
forums, own SQL is still used as of now.

PHPBB3-11595
[feature/api] Added forum entities and models
In this change I added entities to store all fields of
a forum row as an object, later to be serialized using
Symfonys serializer.

A model for API/forum was created to handle data retrieval
of forums.

Controller was split up to be a controller per API, this time
a controller for the API regarding forums.

Services for nestedtree_forums were added as well as for the
API Forum model.

PHPBB3-11595
[feature/api] Implemented the Symfony serializer
A normalizer for the forum entity has been created
with the function of turning the forum entity
object into an array using only the relevant fields
which can then be serialized into either json
or xml (only json for now). This has been done by
using Symfonys Serializer component.

The entity class now uses a getter and a setter.

PHPBB3-11595
[feature/api] Added get_full_tree function
The nested set class can now retrieve the full tree.

PHPBB3-11595
[feature/api] Fixed some small bugs
Fixed a couple of code style mistakes and a couple of small bugs

PHPBB3-11595
[feature/api] Added way to fetch topics
Added a controller, model, entity and normalizer for listing topics.

Changed the way entities work, now uses a data array instead.

Fixed some outdated and wrong comments.

PHPBB3-11595
[feature/api] Reformatting
Replaced space indentation with tab indentation according to the
codestyle guidelines.

Updated normalizers to use arrays to generate outputs.

PHPBB3-11595
[feature/api] Renamed model to repository
Renamed model to repository and updated classes using these.

Added an entity for an API response which would contain HTTP
status codes, data and other information.

Updated path to retrieve topics list, it's now
api/forums/{forum_id}/topics/{page}.

PHPBB3-11595
[feature/api] Rough implementation of API authentication
A rough implementation of API authentication. The application
can request 2 tokens, one authentication token and one signing
token. The application prompts the user to allow access using these
tokens. When making a request, the application should take the
API route and sign it using the signing key using HMAC-SHA256,
for example signing: api/auth/verify/*apitoken*/*timestamp*
then add the resulting hash as the last parameter. The server
does the same calculations to check if the hash is correct.

PHPBB3-11595
[feature/api] Added UCP module for API keys
Added a module in the UCP where a user can see and remove
API keys.

Added permission to be able to use API.

Added config value for enabling and disabling the API.

PHPBB3-11595
[feature/api] Tokens -> Keys
Made names more consistent, changing all occurrences of 'tokens'
to 'keys'.

PHPBB3-11595
[feature/api] Fixed illegal database field name
Renamed field 'key' to 'auth_key'.

PHPBB3-11595
[feature/api] Check if API is enabled on each request
Check if the API is enabled on the board. If not, return a 500 error
with an error message about the API not being enabled.

PHPBB3-11595
[feature/api] Simple API client implementation for development use
A very simple tool to test out different API calls.

PHPBB3-11595
[feature/api] Use helper to generate URLs, removed api_response_entity
Replaced old hard-coded URLs in the Auth controller to use the controller
helper to generate URLs.

Replaced key generator function to use phpBB's uniqueID instead.

PHPBB3-11595
[feature/api] Rebased develop
Rebased the branch and moved the controllers and model folder to
phpBB/phpbb.

PHPBB3-11595
[feature/api] Start with permission control
The auth function in the api auth class now returns the user_id if
the API is enabled and the user can access the API (and the hash
is valid if the user is not a guest).

The forum API now checks if the user has read permission for the forums.

PHPBB3-11595
[feature/api] Removed unnecessary function
The verify function in the auth repository was pretty much useless
after the auth function was implemented. From now on the verify route
uses the auth function instead.

Updated the development API client by implementing running requests
as guest.

PHPBB3-11595
[feature/api] Added tests for the api auth class
Added unit and functional tests for the auth class of the api.

PHPBB3-11595
[feature/api] Updated controllers to use the new auth function
Instead for checking for each point in each controller function
(api enabled, user has permission etc) each controller now calls the
auth function in the api auth class that decides if the user has access
to what he tries to do and returns the users user_id if success or an
error message on failure.

PHPBB3-11595

galaxyAbstractor added some commits Aug 12, 2013

[feature/api] Cleaned up auth test
Removed unused parameter userid.

PHPBB3-11595
[feature/api] Merged topic repo with forum repo
It was confusing that the topic repository and controller returned a
list of topics in a given forum and not a topic with posts. Therefore
the topic listing has been moved to the forum repository to make it
clearer and also to follow the routing pattern better.

PHPBB3-11595
[feature/api] Added API to retrieve the posts in a topic
Added necessary functions to be able to retrieve posts in a given
topic.

PHPBB3-11595
[feature/api] Implemented serial check in authentication
To stop replay attacks and reusing API calls the auth function now
makes sure a request with the same serial or lower hasn't already
been made.

PHPBB3-11595
[feature/api] Creation of topics
Users can now create topics (without polls or attachments) with the
api. Todo: check and add data validation.

PHPBB3-11595
[feature/api] Added function to reply to a thread
Implemented topic reply. Re-organized to shared code between new
topic and reply to avoid code duplication.

TODO:
* Validation, both data and auth
* Consider moving to JSON instead of postdata

PHPBB3-11595
[feature/api] Small fix to check correct permission
Previously the forum repository checked incorrectly for the f_read
permission when listing forums. From now on it checks f_list instead.

PHPBB3-11595
[feature/api] Changed posting to use json instead of multiple post data
Having a post field for each field wasn't optimal due to hashing.
Developers would have to structure their arrays exactly as done in
phpbb. With json ordering doesn't matter as they will have the same
order on both sides when decoded.

PHPBB3-11595
[feature/api] Added permission check for new topic/reply
Now checks that the user can create topics and replies in a forum.
Todo is to make permission checks for announcements, stickies etc.

PHPBB3-11595
[feature/api] Corrected datatypes when serializing JSON
Previously the Symfony Serializer would serialize numbers as strings.
This could lead to various issues when using the API in languages that
enforces data types, where you would get a string where you expected
an int. Now numbers are correctly threated as integers when serializing.

PHPBB3-11595
[feature/api] Added exception throwing to auth repository
Previously the Auth repository would return arrays with errors.
Now they throw an exception instead which can be handled
in a much nicer way.

PHPBB3-11595
[feature/api] Added exception throwing to post and topic
The post and topic repository now throws a
phpbb_model_exception_no_permission_exception if not having
permission to do the action.

PHPBB3-11595
[feature/api] Added pagination to topics and post lists
Now lists current page, the last page, topics/posts per page
and how many topics/posts there are, for easier pagination.

PHPBB3-11595
[feature/api] Added API flag to posts
Added a way to know if a post was made using an API.
TODO: Add icon to posts made by the API for moderators
and administrators to see.

PHPBB3-11595
[feature/api] Added API button to each post
Now shows a button on each post made by the API
to everyone with the m_api permission. It links to the
mcp API key management page that is yet to be made.

PHPBB3-11595
[feature/api] Updated to use namespaces
Rebased the project. Updated to use namespaces to
make the API work with the latest code.

Refactored the auth class a bit to make it work with
the latest code.

PHPBB3-11595
[feature/api] Added version controller
The API is now versioned so that 3rd party developers
can easily know which API a given board is using.

PHPBB3-11595
@fgreinus

This comment has been minimized.

Show comment
Hide comment
@fgreinus

fgreinus Feb 20, 2014

What's up with this one here. Will it take place in 3.1 release?

fgreinus commented Feb 20, 2014

What's up with this one here. Will it take place in 3.1 release?

@galaxyAbstractor

This comment has been minimized.

Show comment
Hide comment
@galaxyAbstractor

galaxyAbstractor Feb 20, 2014

Contributor

@fgreinus I don't think so. I've been busy with work and university for the last couple of months and I'm currently focusing on my bachelor thesis. I am trying to work on this whenever I can but it has been a slow process since work and university has taken up all my time lately.

Contributor

galaxyAbstractor commented Feb 20, 2014

@fgreinus I don't think so. I've been busy with work and university for the last couple of months and I'm currently focusing on my bachelor thesis. I am trying to work on this whenever I can but it has been a slow process since work and university has taken up all my time lately.

@fgreinus

This comment has been minimized.

Show comment
Hide comment
@fgreinus

fgreinus Feb 20, 2014

Thanks for this super-fast reply. Then I'll maybe try to merge it myself.

fgreinus commented Feb 20, 2014

Thanks for this super-fast reply. Then I'll maybe try to merge it myself.

@EXreaction

This comment has been minimized.

Show comment
Hide comment
@EXreaction

EXreaction Feb 20, 2014

Contributor

We're trying to finish the remaining items for a Beta release of 3.1. This would go into 3.2 if it's ready by then.

@galaxyAbstractor This is really a massive project and it would be great to have in phpBB. Is there any way however that it can be split up a little more into multiple PRs? Larger PRs take significantly longer to get merged and don't allow others to contribute as easily.

For example, I see there is an API key system here. Does that work on it's own and could other features use it? If it does and others could use it (which would be very desirable), could you put that in a PR by itself? It could be merged much earlier so that other stuff can use it before the rest of the API is merged.

Then you could make a PR for the base API systems which could be merged, and then a new PR for every API method you'd like to add. Then we could easily be merging some API methods over time and others could help you out as well so some parts of the API are usable while the rest is being developed.

Contributor

EXreaction commented Feb 20, 2014

We're trying to finish the remaining items for a Beta release of 3.1. This would go into 3.2 if it's ready by then.

@galaxyAbstractor This is really a massive project and it would be great to have in phpBB. Is there any way however that it can be split up a little more into multiple PRs? Larger PRs take significantly longer to get merged and don't allow others to contribute as easily.

For example, I see there is an API key system here. Does that work on it's own and could other features use it? If it does and others could use it (which would be very desirable), could you put that in a PR by itself? It could be merged much earlier so that other stuff can use it before the rest of the API is merged.

Then you could make a PR for the base API systems which could be merged, and then a new PR for every API method you'd like to add. Then we could easily be merging some API methods over time and others could help you out as well so some parts of the API are usable while the rest is being developed.

@galaxyAbstractor

This comment has been minimized.

Show comment
Hide comment
@galaxyAbstractor

galaxyAbstractor Feb 20, 2014

Contributor

@EXreaction that sounds like a good plan. The key system should work, you'd only need the auth class and the auth controller for that as well as the template. I dunno though how to split the PR into smaller bits at this point.

However, I think I have to focus on my thesis now, first deadline is tomorrow noon and I have some smaller chapters left to write (about forum systems and implementations of them :))

Contributor

galaxyAbstractor commented Feb 20, 2014

@EXreaction that sounds like a good plan. The key system should work, you'd only need the auth class and the auth controller for that as well as the template. I dunno though how to split the PR into smaller bits at this point.

However, I think I have to focus on my thesis now, first deadline is tomorrow noon and I have some smaller chapters left to write (about forum systems and implementations of them :))

@EXreaction

This comment has been minimized.

Show comment
Hide comment
@EXreaction

EXreaction Feb 20, 2014

Contributor

School does come first :)

The easiest way to split it up would just be to copy the required files (e.g. for the key system) to a new branch and submit a new PR. We would lose commit history, but I think that is fine.

When you do get some time and create a new PR of the key system, let me know and I'll take a look at it. :)

Contributor

EXreaction commented Feb 20, 2014

School does come first :)

The easiest way to split it up would just be to copy the required files (e.g. for the key system) to a new branch and submit a new PR. We would lose commit history, but I think that is fine.

When you do get some time and create a new PR of the key system, let me know and I'll take a look at it. :)

@nickvergessen nickvergessen added this to the 3.2.0-a1 milestone Mar 14, 2014

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Apr 15, 2014

Contributor

Hi @galaxyAbstractor feel free to reopen when you got the time

Contributor

nickvergessen commented Apr 15, 2014

Hi @galaxyAbstractor feel free to reopen when you got the time

galaxyAbstractor added a commit to galaxyAbstractor/phpbb3 that referenced this pull request Oct 31, 2014

[feature/api] API Auth System
The API auth system split into a smaller pull request.
Refer to pull request #1490 for more info.

PHPBB3-11595

galaxyAbstractor added a commit to galaxyAbstractor/phpbb3 that referenced this pull request Dec 28, 2014

[feature/api] API Auth System
The API auth system split into a smaller pull request.
Refer to pull request #1490 for more info.

PHPBB3-11595

galaxyAbstractor added a commit to galaxyAbstractor/phpbb3 that referenced this pull request Jan 17, 2015

[feature/api] API Auth System
The API auth system split into a smaller pull request.
Refer to pull request #1490 for more info.

PHPBB3-11595

galaxyAbstractor added a commit to galaxyAbstractor/phpbb3 that referenced this pull request Feb 15, 2015

[feature/api] API Auth System
The API auth system split into a smaller pull request.
Refer to pull request #1490 for more info.

PHPBB3-11595
@alamops

This comment has been minimized.

Show comment
Hide comment
@alamops

alamops Dec 16, 2015

Well, It sounds good.
Congrats @galaxyAbstractor !!
Was it already approved?

alamops commented Dec 16, 2015

Well, It sounds good.
Congrats @galaxyAbstractor !!
Was it already approved?

@callumacrae

This comment has been minimized.

Show comment
Hide comment
@callumacrae

callumacrae Dec 16, 2015

Contributor

@alamops read the comments above

Contributor

callumacrae commented Dec 16, 2015

@alamops read the comments above

@mtangoo

This comment has been minimized.

Show comment
Hide comment
@mtangoo

mtangoo Jun 18, 2016

Is this going anywhere? @galaxyAbstractor can you comment if you have time to make it into a PHPBB3 somehow?

mtangoo commented Jun 18, 2016

Is this going anywhere? @galaxyAbstractor can you comment if you have time to make it into a PHPBB3 somehow?

@bew

This comment has been minimized.

Show comment
Hide comment
@bew

bew Nov 18, 2016

Hi @galaxyAbstractor,

Any update on this, I'd like to use it, is this PR stable ?
@nickvergessen & others moderators: Do you plan to merge anytime soon ?

bew commented Nov 18, 2016

Hi @galaxyAbstractor,

Any update on this, I'd like to use it, is this PR stable ?
@nickvergessen & others moderators: Do you plan to merge anytime soon ?

@DavidIQ

This comment has been minimized.

Show comment
Hide comment
@DavidIQ

DavidIQ Nov 18, 2016

Member

@Bew78LesellB This was based on a branch that no longer exists, has not been worked on for over 2 years now, and cannot be merged as is without extensive work.

Since this seems to be a recurring theme I'll lock comments now and leave the following note for those that happen to come here: This PR is closed and cannot be merged or used as is. If you are here and would like to continue working on this PR you will need to redo most of it, but might want to take a look at the work done to do your implementation based on it.

Member

DavidIQ commented Nov 18, 2016

@Bew78LesellB This was based on a branch that no longer exists, has not been worked on for over 2 years now, and cannot be merged as is without extensive work.

Since this seems to be a recurring theme I'll lock comments now and leave the following note for those that happen to come here: This PR is closed and cannot be merged or used as is. If you are here and would like to continue working on this PR you will need to redo most of it, but might want to take a look at the work done to do your implementation based on it.

@phpbb phpbb locked and limited conversation to collaborators Nov 18, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.