New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/217] Multiline [url] not converted #155

Merged
merged 5 commits into from Jun 9, 2011

Conversation

Projects
None yet
3 participants
@rxu
Contributor

rxu commented Apr 17, 2011

This is the second attempt parse multiline URL text, see the ticket comments.
PHPBB3-217

@rxu

This comment has been minimized.

Show comment
Hide comment
@rxu

rxu May 1, 2011

Contributor

The patch needs some more fixing, and shouldn't be merged for now.

Contributor

rxu commented May 1, 2011

The patch needs some more fixing, and shouldn't be merged for now.

@rxu rxu closed this May 1, 2011

@rxu rxu reopened this Jun 5, 2011

rxu added some commits Apr 17, 2011

[ticket/217] Multiline [url] not converted
This is the second attempt parse multiline URL text, see the ticket comments.

PHPBB3-217
Show outdated Hide outdated phpBB/includes/message_parser.php Outdated
@p

This comment has been minimized.

Show comment
Hide comment
@p

p Jun 5, 2011

Contributor

And lastly, it looks like the assertions can be made to assert what is rather than what is not:

https://github.com/ur/phpbb3/commit/c8af7d587dd0355ff320320980519a68c84a4346

Contributor

p commented Jun 5, 2011

And lastly, it looks like the assertions can be made to assert what is rather than what is not:

https://github.com/ur/phpbb3/commit/c8af7d587dd0355ff320320980519a68c84a4346

p added some commits Jun 5, 2011

[ticket/217] Silence errors in tests, not code.
Use a mock user object for testing bbcode.

PHPBB3-217
@rxu

This comment has been minimized.

Show comment
Hide comment
@rxu

rxu Jun 6, 2011

Contributor

Added Oleg's commits to the pull request. Squashed ones he mentioned above.

Contributor

rxu commented Jun 6, 2011

Added Oleg's commits to the pull request. Squashed ones he mentioned above.

@naderman naderman merged commit c93164d into phpbb:develop-olympus Jun 9, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment