New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11654] generate_text_for_display on mcp/mcp_warn.php #1586

Merged
merged 3 commits into from Jul 29, 2013

Conversation

Projects
None yet
4 participants
@brunoais
Contributor

brunoais commented Jul 19, 2013

sub-task of ticket PHPBB3-11635:
find and fix all bypasses of generate_text_for_*

PHPBB3-11654

[ticket/11654] generate_text_for_display on mcp/mcp_warn.php
sub-task of ticket PHPBB3-11635:
find and fix all bypasses of generate_text_for_*

PHPBB3-11654

brunoais added some commits Jul 20, 2013

[ticket/11654] first parameter fail
sub-task of ticket PHPBB3-11635:
find and fix all bypasses of generate_text_for_*

PHPBB3-11654
[ticket/11654] Moved some code to reduce line width.
sub-task of ticket PHPBB3-11635:
find and fix all bypasses of generate_text_for_*

PHPBB3-11654
$message = bbcode_nl2br($message);
$message = smiley_text($message);
$parse_flags = OPTION_FLAG_SMILIES | ($row['bbcode_bitfield'] ? OPTION_FLAG_BBCODE : 0);
$message = generate_text_for_display($user_row['post_text'], $user_row['bbcode_uid'], $user_row['bbcode_bitfield'], $parse_flags, true);

This comment has been minimized.

@nickvergessen

nickvergessen Jul 25, 2013

Contributor

Default is true, for censor_text, so you could remove that one.

@nickvergessen

nickvergessen Jul 25, 2013

Contributor

Default is true, for censor_text, so you could remove that one.

This comment has been minimized.

@brunoais

brunoais Jul 25, 2013

Contributor

Even if the default is true, why shouldn't I explicitly display that I want it as true?

@brunoais

brunoais Jul 25, 2013

Contributor

Even if the default is true, why shouldn't I explicitly display that I want it as true?

EXreaction added a commit that referenced this pull request Jul 29, 2013

Merge pull request #1586 from brunoais/ticket/11654
[ticket/11654] generate_text_for_display on mcp/mcp_warn.php

@EXreaction EXreaction merged commit 7003f98 into phpbb:develop Jul 29, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment