Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design for prosilver #1719

Merged
merged 60 commits into from Oct 20, 2013

Conversation

Projects
None yet
2 participants
@cyberalien
Copy link
Contributor

commented Sep 15, 2013

cyberalien added some commits Sep 14, 2013

[ticket/11552] Add link to responsive.css
Add link to responsive.css and blank responsive.css

PHPBB3-11552
[ticket/11552] Basic rules for wrappers and header
Basic rules for content wrapper, common block wrappers and header

PHPBB3-11552
[ticket/11552] Add .nojs or .hasjs to body
Add .nojs to body element, swap it to .hasjs when
JavaScript is enabled

PHPBB3-11552
[ticket/11552] Move breadcrumbs up
Remove spacing between navigation and breadcrumbs
Fix comments format in responsive.css

PHPBB3-11552
[ticket/11552] Limit width of linklists
Limit width of left/right aligned link lists

PHPBB3-11552
[ticket/11552] Insert responsive menu toggle before li.rightside
Insert responsive menu toggle before li.rightside to prevent
li.rightside:last-child css rule from not working

PHPBB3-11552
[ticket/11552] Breadcrumbs in footer, tabs bg color
Change breadcrumbs layout in footer to match breadcrumbs
in header. Change background color for tabs dropdown menu

PHPBB3-11552
[ticket/11552] Responsive paragraphs
Responsive blocks below topics list and misc items

PHPBB3-11552

cyberalien added some commits Oct 18, 2013

[ticket/11552] Fixes for auto-resize textarea
Changing auto-resize code to work with all possible
box-sizing and checking for negative height.

PHPBB3-11552
@cyberalien

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2013

Rebased on latest develop, added some commits.

This PR now also fixes 3 issues:

  • Commit bb0baa4 fixes horizontal overflow for large images (proper fix for ticket PHPBB3-10543 and similar issue with attachments).
  • Commit 12c34e4 fixes textarea auto resize function. (moved to ticket PHPBB3-11946, will be removed during next rebase)
  • Commit f93d2cb fixes issue of long words (like one letter repeated many times) breaking layout, without adding scroll bars. (ticket PHPBB3-4776, marked as won't fix years ago because browsers back then did not support word-wrap, but now they do)

cyberalien added some commits Oct 18, 2013

[ticket/11552] Scrollbars for iOS devices
Show scroll bars for items with overflow on iOS
devices with touch screen that do not show scroll
bars by default

PHPBB3-11552
[ticket/11552] Responsive PM editor
Responsive PM editor, fix quickmod tools

PHPBB3-11552
[ticket/11552] Responsive member list
Responsive member list and better responsive tables

PHPBB3-11552
[ticket/11552] Do not hide all links at once
Do not hide some links as long as their is enough space
to keep them out of dropdown menu

PHPBB3-11552
[ticket/11552] Fix non-square avatars in notifications
Old code was changing all avatars to square. This code
will keep 50px height limit without changing aspect ratio.

PHPBB3-11552
@cyberalien

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2013

PR is ready. Removed [WIP] tag.

naderman added a commit that referenced this pull request Oct 20, 2013

Merge pull request #1719 from cyberalien/ticket/11552
Responsive design for prosilver

@naderman naderman merged commit e08db41 into phpbb:develop Oct 20, 2013

1 check was pending

default The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.