Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ticket/10003 Resolve db_tools proliferation #175

Merged
merged 7 commits into from May 5, 2011

Conversation

Projects
None yet
2 participants
Contributor

p commented Apr 29, 2011

http://tracker.phpbb.com/browse/PHPBB3-10003

Don't close the ticket per ticket comment.

p added some commits Apr 29, 2011

[ticket/10003] Ported 96a30af to db_tools.
This change is somewhat questionable, maybe it should be reviewed.

PHPBB3-10003
[ticket/10003] Ported 54c22ae to db_tools.
This diff applied cleanly.

PHPBB3-10003
[ticket/10003] Ported 023760c to db_tools.
This was painful. Git wanted to patch hunks in wrong places.
Hopefully I got it right.

PHPBB3-10003
[ticket/10003] Ported 5553cfc to db_tools.
The diff in database_update was only partially relevant.

PHPBB3-10003
[ticket/10003] Ported 1802b9f to db_tools.
Most of it was already in db_tools, these changes could have applied to
code that did not exist in db_tools at the time of the commit.

PHPBB3-10003

Newline at end of file?

Nevermind, reverted in later commit.

@naderman naderman merged commit 1e2c19f into phpbb:develop-olympus May 5, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment