New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11935] Fix invalid HTML and Errors #1788

Merged
merged 9 commits into from Nov 4, 2013

Conversation

Projects
None yet
4 participants
@VSEphpbb
Member

VSEphpbb commented Oct 16, 2013

<label> tag can only contain one form element. Most files handle this correctly, but a few I found still had the <input> tag included with the <select> tag inside a <label> tag.
Removed obsolete table attributes (cellpadding, cellspacing), they are handled by CSS
Various fixes to the Extension List in the ACP

http://tracker.phpbb.com/browse/PHPBB3-11935

PHPBB3-11935

border-collapse: separate;
border-spacing: 1px;
}

This comment has been minimized.

@nickvergessen

nickvergessen Oct 23, 2013

Contributor

should be added to table.table1 { definition in prosilver's common.php aswell?

@nickvergessen

nickvergessen Oct 23, 2013

Contributor

should be added to table.table1 { definition in prosilver's common.php aswell?

This comment has been minimized.

@VSEphpbb

VSEphpbb Oct 23, 2013

Member

Prosilver's common.css already has this assigned to the table element, so it's already covered. It was only in the adm/style where there was no existing CSS like this for tables, which is why I added it here.

@VSEphpbb

VSEphpbb Oct 23, 2013

Member

Prosilver's common.css already has this assigned to the table element, so it's already covered. It was only in the adm/style where there was no existing CSS like this for tables, which is why I added it here.

@cyberalien

This comment has been minimized.

Show comment
Hide comment
@cyberalien

cyberalien Oct 29, 2013

Contributor

Looks good, but it causes merge conflicts when merging with latest develop. Can you rebase it?

Contributor

cyberalien commented Oct 29, 2013

Looks good, but it causes merge conflicts when merging with latest develop. Can you rebase it?

@VSEphpbb VSEphpbb closed this Oct 30, 2013

@VSEphpbb VSEphpbb reopened this Oct 30, 2013

@@ -39,7 +39,7 @@
'EXTENSIONS' => 'Extensions',
'EXTENSIONS_ADMIN' => 'Extensions Manager',
'EXTENSIONS_EXPLAIN' => 'The Extensions Manager is a tool in your phpBB Board which allows you to manage all of your extensions statuses and view information about them.',
'EXTENSION_INVALID_LIST' => 'The "%s" extension is not valid.<br /><p>%s</p>',
'EXTENSION_INVALID_LIST' => 'The "%s" extension is not valid.<br />%s<br /><br />',

This comment has been minimized.

@cyberalien

cyberalien Oct 30, 2013

Contributor

Why change this? P is valid tag, it is used to reduce font size of part of error message.

If it is used inside STRONG tag it is better to change STRONG into some other tag like div.bold and add CSS for it.

@cyberalien

cyberalien Oct 30, 2013

Contributor

Why change this? P is valid tag, it is used to reduce font size of part of error message.

If it is used inside STRONG tag it is better to change STRONG into some other tag like div.bold and add CSS for it.

This comment has been minimized.

@VSEphpbb

VSEphpbb Oct 30, 2013

Member

<p> tags are not allowed inside <strong> tags. This entire string is encased inside a strong tag in the template. The p tag here is only used to create a break between lines, so might as well just use actual breaks. At least this is now valid.

@VSEphpbb

VSEphpbb Oct 30, 2013

Member

<p> tags are not allowed inside <strong> tags. This entire string is encased inside a strong tag in the template. The p tag here is only used to create a break between lines, so might as well just use actual breaks. At least this is now valid.

This comment has been minimized.

@cyberalien

cyberalien Oct 30, 2013

Contributor

It is also used for layout. p has font-size: .9em, so second line is smaller than first line.

But increasing font size doesn't really break anything.

@cyberalien

cyberalien Oct 30, 2013

Contributor

It is also used for layout. p has font-size: .9em, so second line is smaller than first line.

But increasing font size doesn't really break anything.

This comment has been minimized.

@VSEphpbb

VSEphpbb Oct 31, 2013

Member

Yes, I checked that out too at the time, and so no harm either.

@VSEphpbb

VSEphpbb Oct 31, 2013

Member

Yes, I checked that out too at the time, and so no harm either.

@cyberalien

This comment has been minimized.

Show comment
Hide comment
@cyberalien

cyberalien Oct 30, 2013

Contributor

I think this is good for merge. Tested it.

Contributor

cyberalien commented Oct 30, 2013

I think this is good for merge. Tested it.

EXreaction added a commit that referenced this pull request Nov 4, 2013

Merge pull request #1788 from VSEphpbb/ticket/11935
[ticket/11935] Fix invalid HTML and Errors

@EXreaction EXreaction merged commit ad69d5a into phpbb:develop Nov 4, 2013

1 check passed

default The Travis CI build passed
Details

@VSEphpbb VSEphpbb deleted the VSEphpbb:ticket/11935 branch Dec 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment