Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ticket/11936] Notification Avatars - Fixes and Restyling #1789

Merged
merged 12 commits into from Oct 20, 2013

Conversation

@VSEphpbb
Copy link
Member

commented Oct 17, 2013

  1. Fix an issue where Avatars overflow into the next list element if the text next to the avatar is 2 lines or less
  2. Remove underline/decoration from the text in the notification window
  3. Use phpBB's no_avatar.gif for users with no avatars in the notification window.
  4. New images for Notification and PM icons and No Avatar (all new images are created from scratch, no licensing concerns)

http://tracker.phpbb.com/browse/PHPBB3-11936
http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=44779

<!-- ELSE -->
<td colspan="2" valign="top">
<!-- ENDIF -->
<td width="50px">

This comment has been minimized.

Copy link
@prototech

prototech Oct 17, 2013

Contributor

This probably doesn't work as "px" shouldn't be specified in the width attribute.

This comment has been minimized.

Copy link
@VSEphpbb

VSEphpbb Oct 17, 2013

Author Member

Hmm, thats actually existing code (I didn't add it, but I can change it)

<!-- ELSE -->
<td colspan="2" valign="top" height="50px">
<!-- ENDIF -->
<td width="50px">

This comment has been minimized.

Copy link
@prototech

prototech Oct 17, 2013

Contributor

Same as previous comment.

VSEphpbb added 8 commits Oct 17, 2013
[ticket/11936] Make UCP Notifications page look even better
Make only the Notification Title/Text the href link. Use a font family
and size consistent with rest of phpBB. Make Notification date
smaller too.

PHPBB3-11936
naderman added a commit that referenced this pull request Oct 20, 2013
Merge pull request #1789 from VSEphpbb/ticket/11936
[Ticket/11936] Notification Avatars - Fixes and Restyling

@naderman naderman merged commit 1aa80b4 into phpbb:develop Oct 20, 2013

1 check was pending

default The Travis CI build is in progress
Details

@VSEphpbb VSEphpbb deleted the VSEphpbb:ticket/11936 branch Oct 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.