Ticket/12143 Making it possible to use translation in group names. #1979

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

neufke commented Feb 1, 2014

No description provided.

neufke added some commits Feb 1, 2014

[ticket/12143] Making it possible to use translation in group names
Making it possible to use translation in group names.

PHPBB3-12143
phpBB/language/en/common.php
@@ -299,6 +299,7 @@
),
'G_ADMINISTRATORS' => 'Administrators',
'G_BOTS' => 'Bots',
+ 'G_FORUM_OWNER' => 'Forum Owner',
@nickvergessen

nickvergessen Feb 2, 2014

Contributor

This is not needed here....

@neufke

neufke Feb 2, 2014

Contributor

You are right, came there because of the example i used to test... Will update it... ;-)

Contributor

nickvergessen commented Feb 2, 2014

I would prefer to have (isset($user->lang['G_' . $group_name])) ? $user->lang['G_' . $group_name] : $group_name; as a function instead of duplicating the code over and over again

neufke added some commits Feb 2, 2014

[ticket/12143] Created a universal function for groupname
If groupname is a var in user->lang starting with G_ then
the translationstring is used, otherwise the name is used.

PHPBB3-12143
Contributor

neufke commented Feb 2, 2014

@nickvergessen: fixed i think

Contributor

nickvergessen commented Mar 19, 2014

@neufke any interest in fixing? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment