Skip to content

Ticket/12155 CSS-ing mini post buttons #2005

Closed
wants to merge 3 commits into from

3 participants

@neufke
neufke commented Feb 4, 2014

No description provided.

neufke added some commits Feb 1, 2014
@neufke neufke [develop] 83073fe
@neufke neufke Merge branch 'develop' of https://github.com/phpbb/phpbb into develop 78e3a8b
@neufke neufke [ticket/12155] CSS-ing of the mini post buttons
Created a css version of the mini post buttons with the use of language vars and no fixed width of height.

PHPBB3-12155
ca522d8
@nickvergessen nickvergessen reopened this Feb 5, 2014
This was referenced Feb 18, 2014
@prototech prototech commented on the diff May 6, 2014
phpBB/includes/acp/acp_styles.php
@@ -1164,7 +1164,7 @@ protected function get_users()
{
$style_count[$row['user_style']] = $row['style_count'];
}
- $this->db->sql_freeresult($result);
+ $this->db->sql_freeresult($result);
@prototech
phpBB Forum Software member
prototech added a note May 6, 2014

Unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech prototech commented on the diff May 6, 2014
phpBB/styles/prosilver/template/ucp_pm_viewmessage.html
@@ -35,7 +35,7 @@
<!-- IF U_PM or U_EMAIL or U_WWW or U_MSN or U_ICQ or U_YIM or U_AIM or U_JABBER -->
<dd>
- <ul class="profile-icons">
+ <ul class="contact-icons">
@prototech
phpBB Forum Software member
prototech added a note May 6, 2014

Unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech prototech commented on the diff May 6, 2014
phpBB/styles/prosilver/template/viewtopic_body.html
@@ -145,7 +145,7 @@
<!-- IF not S_IS_BOT -->
<!-- IF postrow.U_PM or postrow.U_EMAIL or postrow.U_WWW or postrow.U_MSN or postrow.U_ICQ or postrow.U_YIM or postrow.U_AIM or postrow.U_JABBER -->
<dd>
- <ul class="profile-icons">
+ <ul class="contact-icons">
@prototech
phpBB Forum Software member
prototech added a note May 6, 2014

Unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech
phpBB Forum Software member

Please rebase with develop-ascraeus.

@prototech prototech commented on the diff May 6, 2014
phpBB/styles/prosilver/template/viewtopic_body.html
<!-- IF postrow.U_DELETE --><li class="delete-icon"><a href="{postrow.U_DELETE}" title="{L_DELETE_POST}"><span>{L_DELETE_POST}</span></a></li><!-- ENDIF -->
<!-- IF postrow.U_REPORT --><li class="report-icon"><a href="{postrow.U_REPORT}" title="{L_REPORT_POST}"><span>{L_REPORT_POST}</span></a></li><!-- ENDIF -->
<!-- IF postrow.U_WARN --><li class="warn-icon"><a href="{postrow.U_WARN}" title="{L_WARN_USER}"><span>{L_WARN_USER}</span></a></li><!-- ENDIF -->
- <!-- IF postrow.U_INFO --><li class="info-icon"><a href="{postrow.U_INFO}" title="{L_INFORMATION}"><span>{L_INFORMATION}</span></a></li><!-- ENDIF -->
- <!-- IF postrow.U_QUOTE --><li class="quote-icon"><a href="{postrow.U_QUOTE}" title="{L_REPLY_WITH_QUOTE}"><span>{L_REPLY_WITH_QUOTE}</span></a></li><!-- ENDIF -->
+ <!-- IF postrow.U_INFO --><li class="info-icon"><a href="{postrow.U_INFO}" title="{L_INFORMATION}"><span>{L_IP}</span></a></li><!-- ENDIF -->
@prototech
phpBB Forum Software member
prototech added a note May 6, 2014

The post info page contains more than just the IP, so this is rather misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech prototech commented on the diff May 6, 2014
phpBB/styles/prosilver/template/overall_header.html
@@ -26,8 +26,10 @@
-->
<link href="{T_THEME_PATH}/print.css?assets_version={T_ASSETS_VERSION}" rel="stylesheet" type="text/css" media="print" title="printonly" />
-<!-- IF S_ALLOW_CDN --><link href="//fonts.googleapis.com/css?family=Open+Sans:600&amp;subset=latin,cyrillic-ext,latin-ext,cyrillic,greek-ext,greek,vietnamese" rel="stylesheet" type="text/css" media="screen, projection" /><!-- ENDIF -->
-<link href="{T_STYLESHEET_LINK}" rel="stylesheet" type="text/css" media="screen, projection" />
+<!-- IF S_ALLOW_CDN -->
+ <link href="//fonts.googleapis.com/css?family=Open+Sans:600&amp;subset=latin,cyrillic-ext,latin-ext,cyrillic,greek-ext,greek,vietnamese" rel="stylesheet" type="text/css" media="screen, projection" />
+ <link href='//fonts.googleapis.com/css?family=Noto+Sans:400,700&subset=latin,cyrillic-ext,cyrillic,latin-ext,greek-ext,greek,vietnamese' rel='stylesheet' type='text/css' media="screen, projection" />
+<!-- ENDIF --><link href="{T_STYLESHEET_LINK}" rel="stylesheet" type="text/css" media="screen, projection" />
@prototech
phpBB Forum Software member
prototech added a note May 6, 2014

Move the <link> to its own line please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech
phpBB Forum Software member

Replaced by #2469.

@prototech prototech closed this May 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.