Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Ticket/12168 #2015

Closed
wants to merge 4 commits into from

4 participants

@neufke

No description provided.

@prototech prototech commented on the diff
phpBB/includes/acp/acp_styles.php
@@ -1164,7 +1164,7 @@ protected function get_users()
{
$style_count[$row['user_style']] = $row['style_count'];
}
- $this->db->sql_freeresult($result);
+ $this->db->sql_freeresult($result);
@prototech Collaborator

Unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech prototech commented on the diff
phpBB/styles/prosilver/theme/buttons.css
@@ -131,6 +131,10 @@ a.sendemail {
padding: 1px 0 0 17px;
}
+.no-small-icon {
+ padding: 1px 0 0 0;
+}
@prototech Collaborator

I don't like the idea of adding a new class for this because it really doesn't define anything. The default state of the <li> is no icon; there shouldn't be a need to add another class for it. My suggestion would be to move the 1px top-padding definition from .small-icon to the ul.linklist li selector in common.css instead.

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nickvergessen
Collaborator

@neufke can you update this with the suggestion of @prototech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 1, 2014
  1. @neufke

    [develop]

    neufke authored
Commits on Feb 3, 2014
  1. @neufke
Commits on Feb 6, 2014
  1. @neufke
Commits on Feb 8, 2014
  1. @neufke

    [ticket/12168] Nav Header Links Alignment Issues w/o small-icon

    neufke authored
    There are more than 1 ways to get this 1 px added, i just chose
    an easy one (still early over here...)
    
    PHPBB3-12168
This page is out of date. Refresh to see the latest.
View
2  phpBB/includes/acp/acp_styles.php
@@ -1164,7 +1164,7 @@ protected function get_users()
{
$style_count[$row['user_style']] = $row['style_count'];
}
- $this->db->sql_freeresult($result);
+ $this->db->sql_freeresult($result);
@prototech Collaborator

Unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
return $style_count;
}
View
2  phpBB/styles/prosilver/template/overall_header.html
@@ -154,7 +154,7 @@
<a href="{U_PROFILE}" title="{L_PROFILE}" accesskey="e">{L_PROFILE}</a>
</li>
<!-- IF S_DISPLAY_SEARCH -->
- <li class="icon-search-self"><a href="{U_SEARCH_SELF}">{L_SEARCH_SELF}</a></li>
+ <li class="no-small-icon icon-search-self"><a href="{U_SEARCH_SELF}">{L_SEARCH_SELF}</a></li>
<!-- ENDIF -->
<!-- IF U_RESTORE_PERMISSIONS -->
<li class="icon-restore-permissions"><a href="{U_RESTORE_PERMISSIONS}">{L_RESTORE_PERMISSIONS}</a></li>
View
4 phpBB/styles/prosilver/theme/buttons.css
@@ -131,6 +131,10 @@ a.sendemail {
padding: 1px 0 0 17px;
}
+.no-small-icon {
+ padding: 1px 0 0 0;
+}
@prototech Collaborator

I don't like the idea of adding a new class for this because it really doesn't define anything. The default state of the <li> is no icon; there shouldn't be a need to add another class for it. My suggestion would be to move the 1px top-padding definition from .small-icon to the ul.linklist li selector in common.css instead.

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+
ul.linklist li.small-icon {
padding-left: 0;
}
Something went wrong with that request. Please try again.