Ticket/12168 #2015

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

neufke commented Feb 8, 2014

No description provided.

@@ -1164,7 +1164,7 @@ protected function get_users()
{
$style_count[$row['user_style']] = $row['style_count'];
}
- $this->db->sql_freeresult($result);
+ $this->db->sql_freeresult($result);
@prototech

prototech Feb 12, 2014

Contributor

Unrelated.

@@ -131,6 +131,10 @@ a.sendemail {
padding: 1px 0 0 17px;
}
+.no-small-icon {
+ padding: 1px 0 0 0;
+}
@prototech

prototech Feb 12, 2014

Contributor

I don't like the idea of adding a new class for this because it really doesn't define anything. The default state of the <li> is no icon; there shouldn't be a need to add another class for it. My suggestion would be to move the 1px top-padding definition from .small-icon to the ul.linklist li selector in common.css instead.

Contributor

nickvergessen commented Feb 24, 2014

@neufke can you update this with the suggestion of @prototech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment