Skip to content

[ticket/12176] Display correct message when trying to delete founder. #2031

Merged
merged 2 commits into from Mar 13, 2014

3 participants

@bantu
phpBB Forum Software member
bantu commented Feb 15, 2014
@bantu
phpBB Forum Software member
bantu commented Feb 15, 2014

Travis fails because $db->sql_affectedrows() returns 0 for UPDATE queries that do not write anything because the existing value is already the values that we want to update to.

@nickvergessen
phpBB Forum Software member

@bantu ? So what can we do against this?

@bantu
phpBB Forum Software member
bantu commented Feb 22, 2014

@nickvergessen Could ignore the error in set_config().

@nickvergessen
phpBB Forum Software member
@nickvergessen
phpBB Forum Software member

See bantu#6

bantu added some commits Mar 13, 2014
@bantu bantu Merge pull request #6 from nickvergessen/ticket/bantu/12176
[ticket/12176] Add newest_user_colour to config array to ensure it exists

* nickvergessen/ticket/bantu/12176:
  [ticket/12176] Add newest_user_colour to config array to ensure it exists
d3ddf29
@bantu bantu [ticket/12176] Reword comment about config entries.
PHPBB3-12176
e123b0c
@imkingdavid

Looks good and works on olympus. Please submit another PR for inclusion into develop because there's a conflict in the test case, or explain how the conflict should be resolved during a merge.

@nickvergessen nickvergessen merged commit e123b0c into phpbb:develop-olympus Mar 13, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.