Skip to content

[ticket/12201] Clean up ACP attachment management page #2036

Merged
merged 10 commits into from Apr 22, 2014

3 participants

@nickvergessen nickvergessen commented on the diff Feb 22, 2014
phpBB/adm/style/admin.css
@@ -1653,7 +1657,11 @@ input.button1:focus, input.button2:focus, input.button3:focus {
width: auto;
text-align: right;
margin-top: 5px;
+}
+
+.top-pagination {
float: right;
@nickvergessen
phpBB Forum Software member

float: right; is being removed intentionally from .pagination?

@prototech
phpBB Forum Software member
prototech added a note Feb 23, 2014

Correct. It's not needed for the bottom one (3.0 doesn't have it for example) and is actually causing content to move up into the space to the left of the pagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@naderman naderman added the WIP label Feb 24, 2014
@prototech prototech changed the title from WIP [ticket/12201] Clean up ACP attachment management page to [ticket/12201] Clean up ACP attachment management page Apr 15, 2014
@prototech
phpBB Forum Software member

No longer WIP.

@nickvergessen nickvergessen commented on the diff Apr 15, 2014
phpBB/adm/style/acp_attachments.html
@@ -435,10 +430,22 @@
</div>
<!-- ENDIF -->
- <p class="submit-buttons">
- <input class="button1" type="submit" id="submit" name="submit" value="{L_SUBMIT}" />&nbsp;
- <input class="button2" type="reset" id="reset" name="reset" value="{L_RESET}" />
- </p>
+ <fieldset class="display-options">
+ {L_DISPLAY_LOG}{L_COLON} &nbsp;{S_LIMIT_DAYS}&nbsp;{L_SORT_BY}{L_COLON} {S_SORT_KEY} {S_SORT_DIR}
@nickvergessen
phpBB Forum Software member

I think the font here is too small:
2014-04-15_23_40_01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nickvergessen nickvergessen merged commit a9fbc34 into phpbb:develop Apr 22, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@prototech prototech deleted the prototech:ticket/12201 branch Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.