Skip to content

[WIP] [3.2][ticket/11875] Set default data type from MEDIUMINT (3-bytes) to INT(10) (4-bytes) #2064

Closed
wants to merge 3 commits into from

6 participants

@hjpotter92

Use INT(10) data types for user_id, post_id and topic_id across all tables

Resending pull request with develop as the base branch.

PHPBB3-11875

@hjpotter92 hjpotter92 [ticket/11875] Upgrade default data type from MEDIUMINT to INT
Use 4-byte data type INT(10) for user_id, post_id and topic_id across
all tables instead of previously used 3-byte MEDIUMINT(8)

PHPBB3-11875
48fc908
@bantu bantu commented on the diff Mar 2, 2014
phpBB/install/schemas/postgres_schema.sql
@@ -91,7 +91,7 @@ CREATE SEQUENCE phpbb_attachments_seq;
CREATE TABLE phpbb_attachments (
attach_id INT4 DEFAULT nextval('phpbb_attachments_seq'),
post_msg_id INT4 DEFAULT '0' NOT NULL CHECK (post_msg_id >= 0),
- topic_id INT4 DEFAULT '0' NOT NULL CHECK (topic_id >= 0),
@bantu
phpBB Forum Software member
bantu added a note Mar 2, 2014

there is something wrong here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nickvergessen nickvergessen added this to the 3.1.0-b2 milestone Mar 10, 2014
@dhruvgoel92
phpBB Forum Software member

commit messages are not in proper format.
Did you use develop/create_schema_files.php to update the schema?

@nickvergessen
phpBB Forum Software member

@dhruvgoel92 this needs some discussion previously anyway, enhence WIP

@hjpotter92

@dhruvgoel92 Amended the commit message. 👍

@nickvergessen nickvergessen changed the title from [WIP] [ticket/11875] Set default data type from MEDIUMINT (3-bytes) to INT(10) (4-bytes) to [WIP] [3.2][ticket/11875] Set default data type from MEDIUMINT (3-bytes) to INT(10) (4-bytes) May 8, 2014
@nickvergessen nickvergessen removed this from the 3.1.0-b2 milestone Aug 22, 2014
@nickvergessen nickvergessen modified the milestone: 3.2.0 Oct 22, 2014
@marc1706
phpBB Forum Software member

@hjpotter92 What's the status of this? As a heads up, this would require a rebase. You should probably recreate this PR against the current master branch though (replacement for develop).

@Nicofuma
phpBB Forum Software member
Nicofuma commented Jul 3, 2015

@hjpotter92 I'd like to have it in 3.2

Could you rebase and resend the PR as asked by marc? Thank you

@Nicofuma Nicofuma modified the milestone: 3.2.0-a1, 3.2.0-a2 Oct 17, 2015
@Nicofuma Nicofuma modified the milestone: 3.2.0-a2, 3.2.0-a3 Dec 19, 2015
@marc1706
phpBB Forum Software member

Will take over. See #4121

@marc1706 marc1706 closed this Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.