Event to add and/or modify acp_board configurations #2072

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants
@ForumHulp
Contributor

ForumHulp commented Mar 2, 2014

Remarks changed

@Pico

This comment has been minimized.

Show comment Hide comment
@Pico

Pico Mar 2, 2014

Contributor

You shouldn't create a new PR for each changes but update the previous one.

Contributor

Pico commented Mar 2, 2014

You shouldn't create a new PR for each changes but update the previous one.

+ * Event to add and/or modify acp_board configurations
+ *
+ * @event core.acp_config_edit_add
+ * @since 3.1-A4

This comment has been minimized.

Show comment Hide comment
@nickvergessen

nickvergessen Mar 2, 2014

Contributor

3.1.0-a4

@nickvergessen

nickvergessen Mar 2, 2014

Contributor

3.1.0-a4

@prototech

This comment has been minimized.

Show comment Hide comment
@prototech

prototech Mar 2, 2014

Contributor

This still needs a ticket and the commit message edited to follow the proper format as EXreaction pointed out in the previous PR.

Contributor

prototech commented Mar 2, 2014

This still needs a ticket and the commit message edited to follow the proper format as EXreaction pointed out in the previous PR.

@ForumHulp

This comment has been minimized.

Show comment Hide comment
@ForumHulp

ForumHulp Mar 2, 2014

Contributor

After searching for two hours what is wrong I found the line is not starting with a capital. Well both lines starts with a capital and only remarks changed as I wrote in the commit.

Contributor

ForumHulp commented Mar 2, 2014

After searching for two hours what is wrong I found the line is not starting with a capital. Well both lines starts with a capital and only remarks changed as I wrote in the commit.

@EXreaction

This comment has been minimized.

Show comment Hide comment
@EXreaction

EXreaction Mar 3, 2014

Contributor

The commit message should be as follows:

[ticket/12241] Event to add and/or modify acp_board configurations

PHPBB3-12241

The ticket number is what we were referring to, not capitalization.

Thanks for submitting this PR and working on this, if you fix the commit message, the @SInCE line and add $submit to the vars, I think this is good to merge.

Contributor

EXreaction commented Mar 3, 2014

The commit message should be as follows:

[ticket/12241] Event to add and/or modify acp_board configurations

PHPBB3-12241

The ticket number is what we were referring to, not capitalization.

Thanks for submitting this PR and working on this, if you fix the commit message, the @SInCE line and add $submit to the vars, I think this is good to merge.

phpBB/includes/acp/acp_board.php
+ * @since 3.1-A4
+ */
+ global $phpbb_dispatcher;
+ $vars = array('display_vars', 'mode');

This comment has been minimized.

Show comment Hide comment
@EXreaction

EXreaction Mar 3, 2014

Contributor

$submit may be useful as well

@EXreaction

EXreaction Mar 3, 2014

Contributor

$submit may be useful as well

phpBB/includes/acp/acp_board.php
+ * @event core.acp_config_edit_add
+ * @since 3.1-A4
+ */
+ global $phpbb_dispatcher;

This comment has been minimized.

Show comment Hide comment
@prototech

prototech Mar 3, 2014

Contributor

Move to the beginning of the function with the other globals.

@prototech

prototech Mar 3, 2014

Contributor

Move to the beginning of the function with the other globals.

ForumHulp added some commits Mar 3, 2014

Submit added
he commit message should be as follows:
[ticket/12241] Event to add and/or modify acp_board configurations

PHPBB3-12241

@nickvergessen nickvergessen added this to the 3.1.0-b2 milestone Mar 10, 2014

@nickvergessen

This comment has been minimized.

Show comment Hide comment
@nickvergessen

nickvergessen Mar 12, 2014

Contributor

@ForumHulp if you need help with changing the commit messages, just visit our IRC channel #phpbb-dev on the freenode servers

Contributor

nickvergessen commented Mar 12, 2014

@ForumHulp if you need help with changing the commit messages, just visit our IRC channel #phpbb-dev on the freenode servers

@ForumHulp

This comment has been minimized.

Show comment Hide comment
@ForumHulp

ForumHulp Mar 12, 2014

Contributor

I’m assuming the event is added as I cannot see it anymore.

Greetz

http://forumhulp.com/ fhcom
Webhosting, Custom MODs, Technisch beheer, MOD installaties, Webdesign en website ontwikkeling

Van: Joas Schilling [mailto:notifications@github.com]
Verzonden: woensdag 12 maart 2014 19:04
Aan: phpbb/phpbb
CC: Forumhulp.com
Onderwerp: Re: [phpbb] Event to add and/or modify acp_board configurations (#2072)

@ForumHulp https://github.com/ForumHulp if you need help with changing the commit messages, just visit our IRC channel #phpbb-dev on the freenode servers


Reply to this email directly or view it on GitHub #2072 (comment) . https://github.com/notifications/beacon/6719526__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMDI2NjY0NiwiZGF0YSI6eyJpZCI6MjY3NjI2NjV9fQ==--6744b538c54b9304f68cebe857f9014655f51c8a.gif

Contributor

ForumHulp commented Mar 12, 2014

I’m assuming the event is added as I cannot see it anymore.

Greetz

http://forumhulp.com/ fhcom
Webhosting, Custom MODs, Technisch beheer, MOD installaties, Webdesign en website ontwikkeling

Van: Joas Schilling [mailto:notifications@github.com]
Verzonden: woensdag 12 maart 2014 19:04
Aan: phpbb/phpbb
CC: Forumhulp.com
Onderwerp: Re: [phpbb] Event to add and/or modify acp_board configurations (#2072)

@ForumHulp https://github.com/ForumHulp if you need help with changing the commit messages, just visit our IRC channel #phpbb-dev on the freenode servers


Reply to this email directly or view it on GitHub #2072 (comment) . https://github.com/notifications/beacon/6719526__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMDI2NjY0NiwiZGF0YSI6eyJpZCI6MjY3NjI2NjV9fQ==--6744b538c54b9304f68cebe857f9014655f51c8a.gif

@nickvergessen

This comment has been minimized.

Show comment Hide comment
@nickvergessen

nickvergessen Mar 14, 2014

Contributor

Replaced with #2126

Contributor

nickvergessen commented Mar 14, 2014

Replaced with #2126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment