Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Event to add and/or modify acp_board configurations #2072

Closed
wants to merge 3 commits into from

5 participants

@ForumHulp

Remarks changed

@Pico

You shouldn't create a new PR for each changes but update the previous one.

@nickvergessen nickvergessen commented on the diff
phpBB/includes/acp/acp_board.php
@@ -455,6 +455,18 @@ function main($id, $mode)
trigger_error('NO_MODE', E_USER_ERROR);
break;
}
+
+
+ /**
+ * Event to add and/or modify acp_board configurations
+ *
+ * @event core.acp_config_edit_add
+ * @since 3.1-A4
@nickvergessen Collaborator

3.1.0-a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech
Collaborator

This still needs a ticket and the commit message edited to follow the proper format as EXreaction pointed out in the previous PR.

@ForumHulp

After searching for two hours what is wrong I found the line is not starting with a capital. Well both lines starts with a capital and only remarks changed as I wrote in the commit.

@EXreaction

The commit message should be as follows:

[ticket/12241] Event to add and/or modify acp_board configurations

PHPBB3-12241

The ticket number is what we were referring to, not capitalization.

Thanks for submitting this PR and working on this, if you fix the commit message, the @since line and add $submit to the vars, I think this is good to merge.

phpBB/includes/acp/acp_board.php
@@ -455,6 +455,18 @@ function main($id, $mode)
trigger_error('NO_MODE', E_USER_ERROR);
break;
}
+
+
+ /**
+ * Event to add and/or modify acp_board configurations
+ *
+ * @event core.acp_config_edit_add
+ * @since 3.1-A4
+ */
+ global $phpbb_dispatcher;
+ $vars = array('display_vars', 'mode');

$submit may be useful as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
phpBB/includes/acp/acp_board.php
@@ -455,6 +455,18 @@ function main($id, $mode)
trigger_error('NO_MODE', E_USER_ERROR);
break;
}
+
+
+ /**
+ * Event to add and/or modify acp_board configurations
+ *
+ * @event core.acp_config_edit_add
+ * @since 3.1-A4
+ */
+ global $phpbb_dispatcher;
@prototech Collaborator

Move to the beginning of the function with the other globals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
ForumHulp added some commits
@ForumHulp ForumHulp $phpbb_dispatcher moved to top 343eade
@ForumHulp ForumHulp Submit added
he commit message should be as follows:
[ticket/12241] Event to add and/or modify acp_board configurations

PHPBB3-12241
fb8674c
@nickvergessen nickvergessen added this to the 3.1.0-b2 milestone
@nickvergessen
Collaborator

@ForumHulp if you need help with changing the commit messages, just visit our IRC channel #phpbb-dev on the freenode servers

@ForumHulp
@nickvergessen nickvergessen modified the milestone: 3.1.0-b2
@nickvergessen
Collaborator

Replaced with #2126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 2, 2014
  1. @ForumHulp
Commits on Mar 3, 2014
  1. @ForumHulp
  2. @ForumHulp

    Submit added

    ForumHulp authored
    he commit message should be as follows:
    [ticket/12241] Event to add and/or modify acp_board configurations
    
    PHPBB3-12241
This page is out of date. Refresh to see the latest.
Showing with 12 additions and 1 deletion.
  1. +12 −1 phpBB/includes/acp/acp_board.php
View
13 phpBB/includes/acp/acp_board.php
@@ -28,7 +28,7 @@ function main($id, $mode)
{
global $db, $user, $auth, $template;
global $config, $phpbb_root_path, $phpbb_admin_path, $phpEx;
- global $cache, $phpbb_container;
+ global $cache, $phpbb_container, $phpbb_dispatcher;
$user->add_lang('acp/board');
@@ -455,6 +455,17 @@ function main($id, $mode)
trigger_error('NO_MODE', E_USER_ERROR);
break;
}
+
+
+ /**
+ * Event to add and/or modify acp_board configurations
+ *
+ * @event core.acp_config_edit_add
+ * @since 3.1-A4
@nickvergessen Collaborator

3.1.0-a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ */
+ $vars = array('display_vars', 'mode', 'submit');
+ extract($phpbb_dispatcher->trigger_event('core.acp_config_edit_add', compact($vars)));
+
if (isset($display_vars['lang']))
{
Something went wrong with that request. Please try again.