[ticket/11584] Cache results of generate_board_url() in a static variable #2078

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

EXreaction commented Mar 5, 2014

Tests fail.

Member

Elsensee commented Mar 5, 2014

Okay.. it's still failing...
It seems that some unit tests put some wrong urls into the static variables so it will fail.
@naderman why aren't the static variables not empty in different tests?

@nickvergessen nickvergessen added this to the 3.1.0-b2 milestone Mar 10, 2014

Contributor

nickvergessen commented Mar 12, 2014

+
+ if ($board_url !== null)
+ {
+ if (!$without_script_path)
@gooof

gooof Mar 12, 2014

return (!$without_script_path) ? $full_board_url : $board_url;
and the same at the bottom.

@Elsensee Elsensee deleted the Elsensee:ticket/11584 branch Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment