Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[ticket/8785] Rebuilding posting_editor pm head + new language variable for plural. #2082

Merged
merged 12 commits into from Mar 13, 2014

Conversation

Projects
None yet
3 participants

@nickvergessen nickvergessen commented on the diff Mar 3, 2014

phpBB/language/en/ucp.php
@@ -472,7 +472,11 @@
'TIMEZONE' => 'Timezone',
'TIMEZONE_DATE_SUGGESTION' => 'Suggestion: %s',
'TIMEZONE_INVALID' => 'The timezone you selected is invalid.',
- 'TO' => 'To',
+ 'TO' => 'Recipient',
+ 'TO_MASS' => 'Recipients',
@nickvergessen

nickvergessen Mar 3, 2014

Contributor

TO_RECIPIENT and TO_RECIPIENTS? same below?

@nickvergessen

nickvergessen Mar 3, 2014

Contributor

Okay just saw that MASS is already used

Member

Crizz0 commented Mar 4, 2014

I tried to get thease gap: http://ubuntuone.com/2j2YP6chmH94eDAFpVUrYY (idea of prototech) into the posting_editor.html.
But the <div> is opened and closed in "posting_pm_layout.html" and because of the <fieldset> in "posting_editor.html" i'm not able to close and reopen this <div>. Any ideas?

Contributor

nickvergessen commented Mar 5, 2014

@Crizz0 you could move everything inside <!-- IF S_PRIVMSGS and not S_SHOW_DRAFTS --> into a new file, away from the posting_editor.html and put it into a new file that is included into posting_pm_layout.html. That would make posting_editor quite a bit smaller, which I wouldnt even mind ;)

Member

Crizz0 commented Mar 7, 2014

I will see this weekend, if it works well enough. ;)

Member

Crizz0 commented Mar 9, 2014

Travis still has this error:

There were 3 errors:

  1. phpbb_functional_fileupload_form_test::test_empty_file
    InvalidArgumentException: The current node list is empty.

H:\xampp\htdocs\git\phpbb\phpBB\vendor\symfony\dom-crawler\Symfony\Component\Dom
Crawler\Crawler.php:487
H:\xampp\htdocs\git\phpbb\tests\functional\fileupload_form_test.php:68

  1. phpbb_functional_fileupload_form_test::test_invalid_extension
    InvalidArgumentException: The current node list is empty.

H:\xampp\htdocs\git\phpbb\phpBB\vendor\symfony\dom-crawler\Symfony\Component\Dom
Crawler\Crawler.php:487
H:\xampp\htdocs\git\phpbb\tests\functional\fileupload_form_test.php:76

  1. phpbb_functional_fileupload_form_test::test_too_large
    InvalidArgumentException: The current node list is empty.

H:\xampp\htdocs\git\phpbb\phpBB\vendor\symfony\dom-crawler\Symfony\Component\Dom
Crawler\Crawler.php:487
H:\xampp\htdocs\git\phpbb\tests\functional\fileupload_form_test.php:85

←[37;41m←[2KFAILURES!
←[0m←[37;41m←[2KTests: 4, Assertions: 34, Errors: 3.
←[0m←[2K

and if i tried to upload the "empty.png" by myself the error-alert-popup does not show up. But it won't show up for me on 3.1a3 either.

But i just don't know, why "9ef7977" changed, that the tests fails. :/

Contributor

nickvergessen commented Mar 9, 2014

Tests should be fixed with the last commit

@nickvergessen nickvergessen added this to the 3.1.0-b1 milestone Mar 10, 2014

Contributor

prototech commented Mar 11, 2014

There should only be a single set of Add/Add [BCC] buttons as in the screenshot. Having two suggests that these are separate actions, while they're not. Clicking on "Add" in the Groups section will also add any users that you have the recipients textarea and vice versa.

Member

Crizz0 commented Mar 11, 2014

I know. I thought that would be more comfortable for the users. Saving mouse way or something.

So do i have to change this or is this debatable?

Member

Crizz0 commented Mar 11, 2014

Now only one button set has left. :)

@nickvergessen nickvergessen merged commit 21961a2 into phpbb:develop Mar 13, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment