Skip to content

[ticket/12251] Clean up and Enhancement of Custom Profile Fields #2089

Merged
merged 6 commits into from Mar 9, 2014

4 participants

@gooof gooof and 2 others commented on an outdated diff Mar 6, 2014
...ation/data/v310/profilefield_change_load_settings.php
@@ -0,0 +1,30 @@
+<?php
+/**
+*
+* @package migration
+* @copyright (c) 2014 phpBB Group
+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
@gooof
gooof added a note Mar 6, 2014

Illegal whitespace ;)
The same is in 20 other files:
#Line 6: * @license http
phpBB\phpbb\db\migration\data\v310\profilefield_aol_cleanup.php
phpBB\phpbb\db\migration\data\v310\profilefield_icq.php
phpBB\phpbb\db\migration\data\v310\profilefield_icq_cleanup.php
phpBB\phpbb\db\migration\data\v310\profilefield_website_cleanup.php
phpBB\phpbb\db\migration\data\v310\profilefield_wlm_cleanup.php
phpBB\phpbb\db\migration\data\v310\profilefield_yahoo_cleanup.php
tests\compress\compress_test.php
tests\functional\avatar_acp_groups_test.php
tests\functional\avatar_acp_users_test.php
tests\functional\avatar_ucp_groups_test.php
tests\functional\avatar_ucp_users_test.php
tests\functional\common_avatar_test.php
tests\functional\fileupload_form_test.php
tests\functional\fileupload_remote_test.php
tests\functional\plupload_test.php
tests\functional\report_post_captcha_test.php
tests\mock\auth_provider.php
tests\mock\filespec.php
tests\mock\fileupload.php
tests\session\check_ban_test.php
tests\session\create_test.php
tests\session\extract_hostname_test.php
tests\session\extract_page_test.php
tests\session\garbage_collection_test.php
tests\session\session_key_test.php
tests\session\testable_facade.php
tests\session\unset_admin_test.php
tests\session\validate_referrer_test.php
tests\test_framework\phpbb_session_test_case.php
tests\upload\filespec_test.php
tests\upload\fileupload_test.php

@bantu
phpBB Forum Software member
bantu added a note Mar 6, 2014

CodeSniffer does not check these unfortunately.

@bantu
phpBB Forum Software member
bantu added a note Mar 6, 2014

Handle these in a new PR.

@nickvergessen
phpBB Forum Software member
nickvergessen added a note Mar 7, 2014

Sorry, I changed my IDE and it seems to do this everytime, just realised it now.
will have a look at it, to avoid it in future

@nickvergessen
phpBB Forum Software member
nickvergessen added a note Mar 7, 2014

@bantu can't we check for spaces in the beginning of a line?
We should only have tabs there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nickvergessen
phpBB Forum Software member

Should be ready for merge

@EXreaction EXreaction merged commit c169583 into phpbb:develop Mar 9, 2014

1 check passed

Details default The Travis CI build passed
@nickvergessen nickvergessen deleted the nickvergessen:ticket/12251 branch Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.