New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12391] Assign variables to core.posting_modify_template_vars #2305

Merged
merged 1 commit into from Apr 15, 2014

Conversation

Projects
None yet
3 participants
@n-aleha
Contributor

n-aleha commented Apr 14, 2014

Assign variables to event "core.posting_modify_template_vars".
Also, fix a couple of typos.

PHPBB3-12391

n-aleha
[ticket/12391] Assign variables to core.posting_modify_template_vars
Assign variables to event "core.posting_modify_template_vars".
Also, fix a couple of typos.

PHPBB3-12391

nickvergessen added a commit to nickvergessen/phpbb that referenced this pull request Apr 15, 2014

Merge pull request #2305 from n-aleha/ticket/12391
[ticket/12391] Assign variables to core.posting_modify_template_vars

* n-aleha/ticket/12391:
  [ticket/12391] Assign variables to core.posting_modify_template_vars

@nickvergessen nickvergessen merged commit 11c4d14 into phpbb:develop-ascraeus Apr 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@n-aleha n-aleha deleted the n-aleha:ticket/12391 branch Apr 19, 2014

@rfdy

This comment has been minimized.

Show comment
Hide comment
@rfdy

rfdy Apr 25, 2014

Contributor

This change doesn't actually fix the original intent of the jira issue.

The request was to add the template array to the event so that it can be manipulated with variables added to the template.

Contributor

rfdy commented Apr 25, 2014

This change doesn't actually fix the original intent of the jira issue.

The request was to add the template array to the event so that it can be manipulated with variables added to the template.

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Apr 27, 2014

Contributor

@rfdy you can overwrite the variables easily by having code like:

$template->assign_vars(array(
    'MESSAGE' => 'my text',
));

There is no need to add the full array to the event.

Contributor

nickvergessen commented Apr 27, 2014

@rfdy you can overwrite the variables easily by having code like:

$template->assign_vars(array(
    'MESSAGE' => 'my text',
));

There is no need to add the full array to the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment