Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12533] Make <a> use all the container #2450

Merged
merged 2 commits into from May 17, 2014

Conversation

brunoais
Copy link
Contributor

Changed padding CSS to the notifications' <li> and it's <a> (immediate child) so that the <a> block uses all it's container width and height.

To compensate that, I added the padding that was in the <li> to the <a>

PHPBB3-12533

@marc1706
Copy link
Member

This is reported for the two commits:

The following lines are greater than 80 characters long:
3:Changed the CSS so that the <a> of the notifications list for the "see all" uses all the container.

The following lines are greater than 80 characters long:
3:Changed padding CSS to the notifications'

  • and it's (immediate child) so that the block uses all it's container width and height.

  • @brunoais
    Copy link
    Contributor Author

    Thanks for the headsup. I added some newlines to the commit messages to remove those.

    @brunoais
    Copy link
    Contributor Author

    BTW, someone please test this with some detail. My environment is limited in therms of the variety of information and formatting I have available. (additionally, I also tested by applying the style changes in the browser's console while in area51)

    @nickvergessen
    Copy link
    Contributor

    @brunoais please use unique commit subjects (first lines)

    Changed padding CSS to the notifications' `<li>` and it's
    `<a>` (immediate child) so that the `<a>` block uses all
     it's container width and height.
    
    To compensate that, I added the padding that was in the
    `<li>` to the `<a>`
    
    PHPBB3-12533
    Changed the CSS so that the `<a>` of the notifications
    list for the "see all" uses all the container.
    
    PHPBB3-12533
    @brunoais
    Copy link
    Contributor Author

    @nickvergessen Is like that ok?

    @prototech prototech merged commit d27ece1 into phpbb:develop-ascraeus May 17, 2014
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    4 participants