Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12608] Improve notifications drop-down menu styling in header #2510

Merged
merged 9 commits into from Jun 22, 2014

Conversation

PayBas
Copy link
Contributor

@PayBas PayBas commented May 28, 2014

@PayBas PayBas changed the title [ticket/12608] Improve notifications drop-down menu styling in header [WIP] [ticket/12608] Improve notifications drop-down menu styling in header May 28, 2014
'SEARCH_UNANSWERED' => 'View unanswered posts',
'SEARCH_UNREAD' => 'View unread posts',
'SEARCH_UNANSWERED' => 'Unanswered posts',
'SEARCH_UNREAD' => 'Unread posts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, got my files mixed up I see

@nickvergessen
Copy link
Contributor

Please squash the revert ;)

font-size: 1em;
}

.notification_list p.notification-reference,
.notification_list p.notification-location,
.notification_list a.notification-block p.notification-reason {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may look out of place, but not all notifications are links. If there is no link to view the full notification message, we should show the whole "reason" element. Only if it's a link do we hide text-overflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the over-specificity here and simply go with .notification-reference, .notification-location and so on? :)

@PayBas PayBas changed the title [WIP] [ticket/12608] Improve notifications drop-down menu styling in header [ticket/12608] Improve notifications drop-down menu styling in header May 28, 2014
@prototech
Copy link
Contributor

subsilver2? ;-)

@@ -309,10 +309,18 @@ public function prepare_for_display()
return array(
'NOTIFICATION_ID' => $this->notification_id,

'STYLING' => $this->get_styling(),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are all of the blank lines for? Remove them please. :)

@PayBas
Copy link
Contributor Author

PayBas commented Jun 13, 2014

Oh wow, I didn't even know we would have subSilver notifications. Guess I gotta edit that too ;).

edit: done

@prototech
Copy link
Contributor

I'm not entirely convinced about using the red background for those "tagged" as reported since it's not possible to tell whether they're read or unread. Other than that, this should be good to go.

@PayBas
Copy link
Contributor Author

PayBas commented Jun 15, 2014

What did you have in mind? Only show .reported colors for unread reported posts?

@prototech prototech merged commit 1a3c1d5 into phpbb:develop-ascraeus Jun 22, 2014
@PayBas PayBas deleted the ticket/12608 branch June 22, 2014 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants