New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ticket/12608] Improve notifications drop-down menu styling in header #2510
Conversation
'SEARCH_UNANSWERED' => 'View unanswered posts', | ||
'SEARCH_UNREAD' => 'View unread posts', | ||
'SEARCH_UNANSWERED' => 'Unanswered posts', | ||
'SEARCH_UNREAD' => 'Unread posts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, got my files mixed up I see
Please squash the revert ;) |
font-size: 1em; | ||
} | ||
|
||
.notification_list p.notification-reference, | ||
.notification_list p.notification-location, | ||
.notification_list a.notification-block p.notification-reason { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may look out of place, but not all notifications are links. If there is no link to view the full notification message, we should show the whole "reason" element. Only if it's a link do we hide text-overflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the over-specificity here and simply go with .notification-reference, .notification-location
and so on? :)
subsilver2? ;-) |
@@ -309,10 +309,18 @@ public function prepare_for_display() | |||
return array( | |||
'NOTIFICATION_ID' => $this->notification_id, | |||
|
|||
'STYLING' => $this->get_styling(), | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are all of the blank lines for? Remove them please. :)
Oh wow, I didn't even know we would have subSilver notifications. Guess I gotta edit that too ;). edit: done |
I'm not entirely convinced about using the red background for those "tagged" as reported since it's not possible to tell whether they're read or unread. Other than that, this should be good to go. |
PHPBB3-12608
This will allow different notifications to have different styles PHPBB3-12608
PHPBB3-12608
PHPBB3-12608
PHPBB3-12608
What did you have in mind? Only show |
https://tracker.phpbb.com/browse/PHPBB3-12608
http://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=45657
PHPBB3-12608