New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12639] Delete entry in admin-log leads to mysql-error #2526

Merged
merged 11 commits into from Jun 4, 2014

Conversation

Projects
None yet
3 participants
@Nicofuma
Member

Nicofuma commented May 31, 2014

Show outdated Hide outdated tests/log/delete_test.php
Show outdated Hide outdated tests/log/delete_test.php

bantu added a commit to bantu/phpbb that referenced this pull request Jun 2, 2014

Merge pull request phpbb#2526 from Nicofuma/ticket/12639
[ticket/12639] Delete entry in admin-log leads to mysql-error

* Nicofuma/ticket/12639:
  [ticket/12639] Use assertSame
  [ticket/12639] Remove old commented tests
  [ticket/12639] Order the results correctly in the test
  [ticket/12639] Fix tests on postgres
  [ticket/12639] Update tests to use a dataProvider
  [ticket/12639] Add a test case with an empty keywords list
  [ticket/12639] Delete entry in admin-log leads to mysql-error
Show outdated Hide outdated phpBB/phpbb/log/log.php

@bantu bantu merged commit fb46e42 into phpbb:develop-ascraeus Jun 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

bantu added a commit that referenced this pull request Jun 4, 2014

Merge pull request #2526 from Nicofuma/ticket/12639
[ticket/12639] Delete entry in admin-log leads to mysql-error

* Nicofuma/ticket/12639:
  [ticket/12639] Add a space in the code generated by generate_sql_keyword()
  [ticket/12639] Handle $conditions['keywords'] outside of the loop
  [ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
  [ticket/12639] Send a correct IN entry when deleting marked logs
  [ticket/12639] Use assertSame
  [ticket/12639] Remove old commented tests
  [ticket/12639] Order the results correctly in the test
  [ticket/12639] Fix tests on postgres
  [ticket/12639] Update tests to use a dataProvider
  [ticket/12639] Add a test case with an empty keywords list
  [ticket/12639] Delete entry in admin-log leads to mysql-error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment